New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

revert using portal for render menu and add exenv package for checkin… #167

Open

nhuttm wants to merge 1 commit into fkhadra:main from nhuttm:nhuttm/fix-wrong-position-of-menu

nhuttm commented Jan 15, 2021

I have found an issue related to position: fixed. If the parent of Menu has a CSS transform the Menu will fix with its parent.
This PR includes:

Revert drop portal commit for using react portal to render menu.
Add exenv package for checking available dom features


          revert using portal for render menu and add exenv package for checkin…

8e91f51

…g prevent crashing when using dom node

nhuttm force-pushed the nhuttm/fix-wrong-position-of-menu branch from 5bf192c to 8e91f51 Compare

January 15, 2021 07:42

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet