Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

未ログイン状態のトップ画面にGitHubのリンクを追加 #8161

Merged
merged 1 commit into from
Jan 8, 2025
Merged

未ログイン状態のトップ画面にGitHubのリンクを追加 #8161

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/views/shared/_not_logged_in_footer.html.slim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,9 @@ footer.not-logged-in-footer
li.not-logged-in-footer__nav-item
= link_to coc_path, class: 'not-logged-in-footer__nav-item-link' do
| アンチハラスメントポリシー
li.not-logged-in-footer__nav-item
= link_to 'https://github.com/fjordllc/bootcamp', class: 'not-logged-in-footer__nav-item-link' do
| ソースコード
Copy link
Contributor

@mousu-a mousu-a Nov 1, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コミット 74c4962 についてですが、これくらいの変更点であればrebaseして１つのコミットにまとめてしまって良いと思います！
理由としましては、レビュアーは知らなくて良いコミット(履歴)だと思うからです👀
（今から修正する必要はないです！今後の参考までに）

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hagiya0121 (CC: @mousu-a )

こちらできれば修正していただきたいです〜

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@komagata
修正しました🙏

li.not-logged-in-footer__nav-item
= link_to law_path, class: 'not-logged-in-footer__nav-item-link' do
| 特定商取引法に基づく表記
Expand Down
Loading