Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/binary loader #346

Merged
merged 7 commits into from
Mar 13, 2025
Merged

Fix/binary loader #346

merged 7 commits into from
Mar 13, 2025

Conversation

xinyuli1204
Copy link
Contributor

@xinyuli1204 xinyuli1204 commented Mar 6, 2025

This pr includes 4 changes

  1. replace ::std:: to std::
  2. fix logic , rewrite reader since reader used to read bin file that includes header file followed with framecount and 2 images

before

header (512)
framecount
image0
image1
framecount
image0
image1
........

Now it only have frame count and 1 image

now

framecount
image
framecount
image
........
  1. Fix BinaryLoader errors
    That is en error comes from halide when building the pipeline
Error: All Params and embedded Buffers must have unique names, but the name 'b3' was seen multiple times.

fix it by not using shared paramers.

  1. extend binary loader from uint16 to uint8 and handle dispose in a better way

@xinyuli1204 xinyuli1204 changed the title (WIP) Fix binary loader (WIP) Fix/binary loader Mar 6, 2025
@xinyuli1204 xinyuli1204 changed the title (WIP) Fix/binary loader Fix/binary loader Mar 7, 2025
@xinyuli1204 xinyuli1204 marked this pull request as draft March 7, 2025 00:03
@xinyuli1204 xinyuli1204 changed the title Fix/binary loader (WIP)Fix/binary loader Mar 7, 2025
@xinyuli1204 xinyuli1204 changed the title (WIP)Fix/binary loader Fix/binary loader Mar 12, 2025
@xinyuli1204 xinyuli1204 marked this pull request as ready for review March 12, 2025 20:47
@Fixstars-momoko Fixstars-momoko merged commit bd2c4b3 into main Mar 13, 2025
3 checks passed
@xinyuli1204 xinyuli1204 deleted the fix/binary-loader branch March 13, 2025 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants