Add UseStateForUnknown plan modifier to is_primary_key attribute #490
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added UseStateForUnknown() plan modifier to prevent noisy terraform plan output - Changed is_primary_key from Optional+Computed to Computed-only (read-only field) - Applied to both new schemas format and legacy schema format - Eliminates unnecessary '(known after apply)' diffs for unchanged primary key attributes Root cause: Previous fixes (v1.9.9-v1.9.11) tried model-based approaches, but the standard Terraform Framework solution is UseStateForUnknown plan modifier. This tells Terraform to use the state value for unchanged computed fields during plan. Without this modifier, Optional+Computed attributes show as '(known after apply)' for every column, making plan output unreadable for large schemas (hundreds of tables). Testing: - All existing unit tests pass - TestResourceSchemaPrimaryKeyComputedMock: validates no is_primary_key in PATCH - TestResourceSchemaPrimaryKeyNullDefaultMock: validates null defaults - TestResourceSchemaPrimaryKeyLargeSchemaNoNoiseMock: validates at scale - Manual terraform plan test: confirms no is_primary_key noise in output
- Bumped provider version from 1.9.15 to 1.9.16 - Added CHANGELOG entry documenting the is_primary_key fix - Documents that UseStateForUnknown plan modifier eliminates noisy plan output
fivetran-renat-sh
approved these changes
Nov 28, 2025
Contributor
fivetran-renat-sh
left a comment
fivetran-renat-sh
left a comment
There was a problem hiding this comment.
Looks good! Thank you!
fivetran-jovanmanojlovic
deleted the
fix-noisy-plan-output-use-state-for-unknown
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause: Previous fixes (v1.9.9-v1.9.11) tried model-based approaches, but the standard Terraform Framework solution is UseStateForUnknown plan modifier. This tells Terraform to use the state value for unchanged computed fields during plan.
Without this modifier, Optional+Computed attributes show as '(known after apply)' for every column, making plan output unreadable for large schemas (hundreds of tables).
Testing: