Readme and integration test persist docs update#46
Merged
fivetran-joemarkiewicz merged 2 commits intoMar 2, 2026
Conversation
Comment on lines
+28
to
+29
| relation: true | ||
| columns: "{{ false if target.type in ('databricks') else true }}" |
Contributor
There was a problem hiding this comment.
@fivetran-joemarkiewicz Just want to double check it was intentional to omit spark?
Collaborator
There was a problem hiding this comment.
@fivetran-catfritz correct, in our integration tests we actually only use the target.type = databricks. If we were to include spark here it wouldn't actually be used in our integration tests.
fivetran-catfritz
approved these changes
Mar 2, 2026
fivetran-joemarkiewicz
deleted the
feature/readme-and-persist-docs-update
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary