-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow multiple pdf files to be converted #40
Open
litemikx
wants to merge
22
commits into
fitraditya:develop
Choose a base branch
from
litemikx:feature
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 21 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
2f06a2b
Update version.
764a48a
Update README.
5e613ac
Merge branch 'develop' of https://github.com/fitraditya/node-pdf2img
9e5c177
Update README, remove ImageMagick as dependency.
fc3a371
Bump version.
b75d5c3
feature: add options.page
revolunet 7b76501
Merge pull request #26 from revolunet/master
abe6e81
Check given selected page and total page number.
a0009cf
Make callback return.
8bce0ad
Update test.
be8fe54
Update readme.
3a5f48c
Bump new version.
f65c795
Fixed using gm as node_module to identify pages
05cefa0
Merge pull request #29 from vlados/master
2c9664d
Update README.md
artcoding-git 9f9f83c
Merge pull request #31 from artcoding-git/patch-1
f7a4b42
Feature: Convert multiple pdf files
litemikx 36b03ec
Allow multiple pdf files to be converted
litemikx 9d1ec42
Merge remote-tracking branch 'refs/remotes/origin/master' into feature
litemikx 1df7531
Allow multiple pdf files to be converted
litemikx be438f8
Merge remote-tracking branch 'refs/remotes/origin/develop' into feature
litemikx 0c70b8f
updated assignment on options
litemikx File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,6 @@ | ||
{ | ||
"name": "pdf2img", | ||
"version": "0.2.0", | ||
"version": "0.5.0", | ||
"description": "A nodejs module for converting pdf into image", | ||
"author": "Fitra Aditya <[email protected]>", | ||
"license": "MIT", | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem right, now if options has already value and it is not given in opts it will be overridden with undefined.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback, I made another commit that should handle assignments on the options variable.