SLATE: prevent Cofunction reassembly #4377
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pbrubeck
force-pushed
the
pbrubeck/fix/slate-cofunction
branch
from
f09232d to
1abec01
Compare
connorjward
reviewed
Jun 16, 2025
connorjward
reviewed
Jun 16, 2025
pbrubeck
force-pushed
the
pbrubeck/fix/slate-cofunction
branch
from
0a65da3 to
6e5c84a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Here we avoid implicit casting of Cofunctions into SLATE expressions when forming the residual
F=a*u-Lof aLinearVariationalProblem, as SLATE will always sum the cell contributions into the output vector. Instead, we deal with linear combinations of SLATE expressions andCofunctionsviaFormSum, so the Cofunction gets excluded from the sum over elements.We also extend BaseForm assembly to BaseForm objects with SLATE nodes.
Fixes #4376