-
Notifications
You must be signed in to change notification settings - Fork 166
Eikehmueller/gtmgpc restriction #4373
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: release
Are you sure you want to change the base?
Conversation
Could you checkout release, pull, and merge release into this branch so the unrelated commits go away? |
just did
but that doesn't seem to change anything. |
Ah, the merge was set into master, I just changed it now to release |
This looks good but we need to add tests to make sure these features remain supported, including a test for the custom interpolation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. Thanks!
a8c550b
to
21b034e
Compare
21b034e
to
765ade7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That exceeded expectations! Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Once release is merged into master (hopefully later today) you can update this branch with the link fixes so all the workflows pass, and we can get this merged |
Description
Add functionality to pass an optional restriction matrix to
GTMGPC
.fixes #4367
At the moment, only the interpolation matrix of the
pcmg
object can be specified through theappctx
via"interpolation_matrix":interp_petscmat
and the restriction matrix is automatically set to the transpose of this. The changes in this PR allow passing the restriction matrix through theappctx
via"restriction_matrix":restr_petscmat
. If no restriction matrix is specified, it defaults to the transpose of the interpolation matrix as before, hence the change is backward compatible.