Skip to content

Eikehmueller/gtmgpc restriction #4373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: release
Choose a base branch
from

Conversation

eikehmueller
Copy link
Contributor

Description

Add functionality to pass an optional restriction matrix to GTMGPC.

fixes #4367

At the moment, only the interpolation matrix of the pcmg object can be specified through the appctx via "interpolation_matrix":interp_petscmat and the restriction matrix is automatically set to the transpose of this. The changes in this PR allow passing the restriction matrix through the appctx via "restriction_matrix":restr_petscmat. If no restriction matrix is specified, it defaults to the transpose of the interpolation matrix as before, hence the change is backward compatible.

@eikehmueller eikehmueller requested a review from pbrubeck June 13, 2025 10:17
@eikehmueller eikehmueller marked this pull request as draft June 13, 2025 10:18
@pbrubeck
Copy link
Contributor

Could you checkout release, pull, and merge release into this branch so the unrelated commits go away?

@eikehmueller
Copy link
Contributor Author

just did

git checkout release
git pull
git checkout eikehmueller/gtmgpc-restriction
git merge release
git push

but that doesn't seem to change anything.

@pbrubeck pbrubeck changed the base branch from master to release June 13, 2025 10:55
@pbrubeck
Copy link
Contributor

pbrubeck commented Jun 13, 2025

Ah, the merge was set into master, I just changed it now to release

@pbrubeck
Copy link
Contributor

pbrubeck commented Jun 13, 2025

This looks good but we need to add tests to make sure these features remain supported, including a test for the custom interpolation

@pbrubeck pbrubeck marked this pull request as ready for review June 17, 2025 08:30
pbrubeck
pbrubeck previously approved these changes Jun 18, 2025
Copy link
Contributor

@pbrubeck pbrubeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Thanks!

@pbrubeck pbrubeck force-pushed the eikehmueller/gtmgpc-restriction branch from a8c550b to 21b034e Compare June 18, 2025 14:26
@pbrubeck pbrubeck force-pushed the eikehmueller/gtmgpc-restriction branch from 21b034e to 765ade7 Compare June 18, 2025 14:31
connorjward
connorjward previously approved these changes Jun 18, 2025
Copy link
Contributor

@connorjward connorjward left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That exceeded expectations! Thank you!

@JHopeCollins JHopeCollins self-requested a review June 18, 2025 17:25
JHopeCollins
JHopeCollins previously approved these changes Jun 18, 2025
Copy link
Member

@JHopeCollins JHopeCollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pbrubeck pbrubeck requested a review from JHopeCollins June 24, 2025 07:58
@JHopeCollins
Copy link
Member

Once release is merged into master (hopefully later today) you can update this branch with the link fixes so all the workflows pass, and we can get this merged

@JHopeCollins JHopeCollins self-requested a review July 2, 2025 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pass restriction matrix to GTMGPC
5 participants