Knook/multicomponent #4322
Knook/multicomponent #4322
Conversation
|
The references are not showing using |
* Small suggestions * Don't mention Gibbs-Duhem without explaining later * Change initial paragraph
| :math:`v_i^\text{ref}` are reference velocities that we are free to choose. | ||
| Elsewhere on the boundary we enforce :math:`J_i \cdot N = 0`. Finally, instead of specifying | ||
| the value of the barycentric velocity :math:`v` on the inflows and outflows, | ||
| we enforce :math:`v = \rho^{-1}((J_1 + J_2)\cdot N)N`. Boundary conditions that couple |
There was a problem hiding this comment.
The inflow boundaries are normal to the y-axis. However the parabolic inflow has a component in the x-axis. This conflicts with the claim that you had before cross(v, N) = 0, and the current statement v = (scalar) N.
There was a problem hiding this comment.
You're right, thanks for catching that -- what we wrote here is correct for the 3D Benzene simulation from my paper but I guess we forgot that the BCs are slightly different in this 2D simulation.
I just pushed a commit that rephrases this paragraph, please resolve if you're happy with it.
Clarify that (1 / specific volume) = density. Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor wording change Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
Minor formatting changes Co-authored-by: Pablo Brubeck <[email protected]>
|
@pbrubeck Thanks for all the suggestions. We are currently failing the tests because, when building the documentation, latex isn't aware of |
|
Feel free to make the change to support that latex command, or use another symbol |
Demo for multicomponent flows -- microfluidic mixing of hydrocarbons