Skip to content

v0.5: snapshot download improvements, gui pacing #5153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

v0.5: snapshot download improvements, gui pacing #5153

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da05fb1
agave, snapshot: add download-abort param, delay download speed check
jherrera-jump May 15, 2025
0ee99d9
gui: fix pacing, reverse leader slot order
jherrera-jump May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion agave
Open in desktop
Submodule agave updated 1 files
+3 −2 validator/src/bootstrap.rs
1 change: 1 addition & 0 deletions src/app/fdctl/commands/run_agave.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,6 +166,7 @@ agave_boot( config_t const * config ) {
if( strcmp( "", config->snapshots.incremental_path ) ) ADD( "--incremental-snapshot-archive-path", config->snapshots.incremental_path );
ADDU( "--maximum-snapshots-to-retain", config->snapshots.maximum_full_snapshots_to_retain );
ADDU( "--maximum-incremental-snapshots-to-retain", config->snapshots.maximum_incremental_snapshots_to_retain );
ADDU( "--maximum-snapshot-download-abort", config->snapshots.maximum_snapshot_download_abort );
ADDU( "--minimal-snapshot-download-speed", config->snapshots.minimum_snapshot_download_speed );

if( config->layout.agave_unified_scheduler_handler_threads ) {
Expand Down
8 changes: 8 additions & 0 deletions src/app/fdctl/config/default.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -398,6 +398,14 @@ dynamic_port_range = "8900-9000"
# client with the `--minimum-snapshot-download-speed` argument.
minimum_snapshot_download_speed = 10485760

# The maximum number of times to abort and retry when encountering a
# slow snapshot download.
#
# The default value is 5 retries. This option is passed to the
# Agave client with the `--maximum-snapshot-download-abort`
# argument.
maximum_snapshot_download_abort = 5

# Absolute directory path for storing snapshots. If no path is
# provided, it defaults to the [ledger.path] option from above.
#
Expand Down
1 change: 1 addition & 0 deletions src/app/shared/fd_config.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -237,6 +237,7 @@ struct fd_config {
int incremental_snapshots;
uint full_snapshot_interval_slots;
uint incremental_snapshot_interval_slots;
uint maximum_snapshot_download_abort;
uint minimum_snapshot_download_speed;
uint maximum_full_snapshots_to_retain;
uint maximum_incremental_snapshots_to_retain;
Expand Down
2 changes: 2 additions & 0 deletions src/app/shared/fd_config_parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -263,6 +263,7 @@ fdctl_pod_to_cfg( config_t * config,
CFG_POP ( bool, snapshots.incremental_snapshots );
CFG_POP ( uint, snapshots.full_snapshot_interval_slots );
CFG_POP ( uint, snapshots.incremental_snapshot_interval_slots );
CFG_POP ( uint, snapshots.maximum_snapshot_download_abort );
CFG_POP ( uint, snapshots.minimum_snapshot_download_speed );
CFG_POP ( uint, snapshots.maximum_full_snapshots_to_retain );
CFG_POP ( uint, snapshots.maximum_incremental_snapshots_to_retain);
Expand Down Expand Up @@ -501,6 +502,7 @@ fdctl_cfg_validate( config_t * cfg ) {

CFG_HAS_NON_ZERO( snapshots.full_snapshot_interval_slots );
CFG_HAS_NON_ZERO( snapshots.incremental_snapshot_interval_slots );
CFG_HAS_NON_ZERO( snapshots.maximum_snapshot_download_abort );
CFG_HAS_NON_ZERO( snapshots.minimum_snapshot_download_speed );

CFG_HAS_NON_EMPTY( layout.affinity );
Expand Down
6 changes: 3 additions & 3 deletions src/disco/gui/dist/assets/index-Dm_aFr8M.js → src/disco/gui/dist/assets/index-BFJcgdxv.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/disco/gui/dist/assets/index-Bwdiu9KE.js → src/disco/gui/dist/assets/index-DjLLGYQR.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion src/disco/gui/dist/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
/>
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>Firedancer</title>
<script type="module" crossorigin src="/assets/index-Dm_aFr8M.js"></script>
<script type="module" crossorigin src="/assets/index-BFJcgdxv.js"></script>
<link rel="stylesheet" crossorigin href="/assets/index-CULNhLeN.css">
</head>
<body>
Expand Down
8 changes: 4 additions & 4 deletions src/disco/gui/generated/http_import_dist.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,9 @@

FD_IMPORT_BINARY( file0, "src/disco/gui/dist/assets/firedancer-D_J0EzUc.svg" );
FD_IMPORT_BINARY( file1, "src/disco/gui/dist/assets/firedancer_logo-CrgwxzPk.svg" );
FD_IMPORT_BINARY( file2, "src/disco/gui/dist/assets/index-Bwdiu9KE.js" );
FD_IMPORT_BINARY( file2, "src/disco/gui/dist/assets/index-BFJcgdxv.js" );
FD_IMPORT_BINARY( file3, "src/disco/gui/dist/assets/index-CULNhLeN.css" );
FD_IMPORT_BINARY( file4, "src/disco/gui/dist/assets/index-Dm_aFr8M.js" );
FD_IMPORT_BINARY( file4, "src/disco/gui/dist/assets/index-DjLLGYQR.js" );
FD_IMPORT_BINARY( file5, "src/disco/gui/dist/assets/index-Dobne4Xk.css" );
FD_IMPORT_BINARY( file6, "src/disco/gui/dist/assets/inter-tight-latin-400-normal-BW_APOAv.woff" );
FD_IMPORT_BINARY( file7, "src/disco/gui/dist/assets/inter-tight-latin-400-normal-CjmW70MP.woff2" );
Expand All @@ -25,7 +25,7 @@ fd_http_static_file_t STATIC_FILES[] = {
.data_len = &file1_sz,
},
{
.name = "/assets/index-Bwdiu9KE.js",
.name = "/assets/index-BFJcgdxv.js",
.data = file2,
.data_len = &file2_sz,
},
Expand All @@ -35,7 +35,7 @@ fd_http_static_file_t STATIC_FILES[] = {
.data_len = &file3_sz,
},
{
.name = "/assets/index-Dm_aFr8M.js",
.name = "/assets/index-DjLLGYQR.js",
.data = file4,
.data_len = &file4_sz,
},
Expand Down
Loading