fix(test): skip test_cpu_topology test on Ubuntu #5496
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bchalios
added
the
Status: Awaiting review
kalyazin
previously approved these changes
Oct 30, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5496 +/- ##
=======================================
Coverage 82.84% 82.84%
=======================================
Files 269 269
Lines 27737 27737
=======================================
Hits 22978 22978
Misses 4759 4759
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zulinx86
reviewed
Oct 30, 2025
bchalios
force-pushed
the
skip_cpu_topology_test_on_ubuntu
branch
3 times, most recently
from
a6ebc9a to
9cbf236
Compare
On Aarch64 systems we do not normalize vCPUs, we let KVM configure them. This means that the CPU cache hierarchy exposed to the guest depends entirely on what the KVM decides it to be. We observed that when we're running tests on Ubuntu hosts with a 6.14 kernel the cache hierarchy is different than the one we expect on AL hosts. Until we decide how to deal with CPU hierarchy in a controled way (or not) skip the test on Ubuntu systems. The actual test checks that the host kernel version is greater or equal to 6.14. Signed-off-by: Babis Chalios <[email protected]>
bchalios
force-pushed
the
skip_cpu_topology_test_on_ubuntu
branch
from
9cbf236 to
3211563
Compare
zulinx86
reviewed
Oct 30, 2025
zulinx86
approved these changes
Oct 30, 2025
kalyazin
approved these changes
Oct 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Aarch64 systems we do not normalize vCPUs, we let KVM configure them. This means that the CPU cache hierarchy exposed to the guest depends entirely on what the KVM decides it to be.
We observed that when we're running tests on Ubuntu hosts with a 6.14 kernel the cache hierarchy is different than the one we expect on AL hosts.
Until we decide how to deal with CPU hierarchy in a controlled way (or not) skip the test on Ubuntu systems.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.