Skip to content

doc(net): remove instruction for nameserver setup via boot_args #5214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kalyazin
Copy link
Contributor

Changes

Remove instruction for nameserver setup via boot_args.
Related issue: #5172 .

Reason

It does not work with our current rootfs.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
    - [ ] I have mentioned all user-facing changes in CHANGELOG.md.
    - [ ] If a specific issue led to this PR, this PR closes the issue.
    - [ ] When making API changes, I have followed the
    Runbook for Firecracker API changes.

    - [ ] I have tested all new and changed functionalities in unit tests and/or
    integration tests.

    - [ ] I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

It does not work with our current rootfs.

Signed-off-by: Nikita Kalyazin <[email protected]>
@kalyazin kalyazin self-assigned this May 16, 2025
@kalyazin kalyazin added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants