Skip to content

Adding support for Seqpacket #5197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bstrong04
Copy link

@bstrong04 bstrong04 commented May 7, 2025

Changes

Adding support for the VSOCKSEQPACKET type in VIRTIO devices (specifically VSOCK). Aims to add message handling differences in SEQPACKETs and allow for the creation of socket types / buffers used in event handling.

Still very W.I.P.

...

Reason

Currently this is unsupported by firecracker and would allow for stricter message sending protocols for the host and guest to allow for expectations of limited message behavior (one message per receive/send).

Closes #4822

Done in part with @gjkeller.

...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@bstrong04 bstrong04 changed the title Seqpacket Adding support for Seqpacket May 7, 2025
@zulinx86 zulinx86 requested a review from JackThomson2 May 14, 2025 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Add SEQPACKET socket type for vsock
2 participants