[Firebase AI] Move GOOGLEAPPMEASUREMENT flag into test.sh
#1702
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @andrewheard, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request moves the FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT flag from the firebaseai workflow to test.sh. This change is intended to handle SPM builds when GoogleAppMeasurement has not yet been released, preparing for future SPM-based quickstarts. The flag points SPM CI to the tip of main of the GoogleAppMeasurement repository, allowing the release process to defer publishing the GoogleAppMeasurement tag until after testing.
Highlights
- Flag Relocation: The
FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENTflag has been moved from thefirebaseaiworkflow totest.sh. - SPM Build Handling: This change addresses SPM builds when
GoogleAppMeasurementis not yet released. - Future-Proofing: The pull request prepares for future SPM-based quickstarts.
Changelog
- scripts/test.sh
- Added
export FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT=1to point SPM CI to the tip ofmainof the GoogleAppMeasurement repository (lines 134-137).
- Added
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A flag's migration,
For builds in anticipation,
Of SPM's embrace,
A testing space,
Before the final publication.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request moves the FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENT flag from the firebaseai workflow to test.sh. This change aims to handle SPM builds when GoogleAppMeasurement has not yet been released, preparing for future SPM-based quickstarts. The change looks straightforward and addresses the stated goal.
Merge Readiness
The pull request appears to be ready for merging. The change is small and well-explained in the description. I am unable to directly approve the pull request, and other reviewers should review and approve this code before merging.
|
I manually triggered a run of the workflow in https://github.com/firebase/quickstart-ios/actions/runs/14894840997/job/41835191968 |
Moved the
FIREBASECI_USE_LATEST_GOOGLEAPPMEASUREMENTflag from thefirebaseaiworkflow totest.shto handle the SPM builds whenGoogleAppMeasurementhas not yet been released. This is to prepare for future SPM-based quickstarts. See #1701 for the original fix.