Skip to content

Commit

Permalink
First start at supporting a nodeExecutable setting in dataconnect.loc…
Browse files Browse the repository at this point in the history
…al.toml
  • Loading branch information
dconeybe committed Nov 19, 2024
1 parent a66e0ae commit b598af6
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,11 @@ import kotlinx.serialization.Serializable
import kotlinx.serialization.Transient

@Serializable
internal data class LocalConfig(val npmExecutable: String? = null, @Transient val srcFile: File? = null) :
internal data class LocalConfig(
val npmExecutable: String? = null,
val nodeExecutable: String? = null,
@Transient val srcFile: File? = null
) :
java.io.Serializable {
companion object {
@Suppress("ConstPropertyName")
Expand Down
15 changes: 15 additions & 0 deletions dataconnect/dataconnect.local.toml
Original file line number Diff line number Diff line change
Expand Up @@ -6,5 +6,20 @@
# path of the npm executable to use works around that problem. Setting it to null
# uses "npm" as found in the PATH.
#
# NOTE: If this value is set then you almost certainly want to set nodeExecutable
# as well.
#
# eg. npmExecutable = "/home/myusername/local/nvm/versions/node/v20.13.1/bin/npm"
npmExecutable = null

# The path of the "node" executable to use to run the "firebase" command.
# Setting this is normally not necessary; however, if "node" is not in the global
# PATH, or the wrong version is in the global PATH, then setting this to the absolute
# path of the node executable to use works around that problem. Setting it to null
# uses "node" as found in the PATH.
#
# NOTE: If this value is set then you almost certainly want to set npmExecutable
# as well.
#
# eg. nodeExecutable = "/home/myusername/local/nvm/versions/node/v20.13.1/bin/node"
nodeExecutable = null

1 comment on commit b598af6

@dconeybe
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Vonssgh Did you mean to comment on this PR? I don't see the connection with this PR. If you have an issue with the Firebase Android SDK, please feel free to open an issue at https://github.com/firebase/firebase-android-sdk/issues/new?template=bug.md.

Please sign in to comment.