Skip to content

docs(app_check): mark Windows support as development-only - #18914

Open
Adrianogba wants to merge 1 commit into
firebase:mainfrom
Adrianogba:docs/app-check-windows-readme
Open

Adrianogba wants to merge 1 commit into
firebase:mainfrom
Adrianogba:docs/app-check-windows-readme

Conversation

@Adrianogba

Copy link
Copy Markdown

Description

The stable plugins table still lists App Check as N/A on Windows. Windows support shipped in firebase_app_check 0.4.3 (#18140), and the other Windows C++ plugins in that table (Authentication, Cloud Firestore, Cloud Storage, Core, and Remote Config) are marked (*): development only, with production unsupported.

This changes the App Check Windows cell from N/A to (*).

Related Issues

Fixes #18913

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Test plan

  • The App Check row in the README stable plugins table shows (*) under Windows, and the footnote under the table is unchanged.

The README still lists App Check as unavailable on Windows after support shipped in 0.4.3. Use the same development-only marker as the other Windows C++ plugins.

Fixes firebase#18913

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the README.md file to reflect that Windows support for App Check is now available under certain conditions, changing its status from 'N/A' to '(*)'. There are no review comments, and I have no additional feedback to provide.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[📚] App Check Windows Support still N/A on Readme

1 participant