Repository navigation
docs(data_connect): mark Windows support as development-only - #18912
Open
Adrianogba wants to merge 1 commit into
Open
Adrianogba wants to merge 1 commit into
Adrianogba wants to merge 1 commit into
Conversation
The README still lists Data Connect as unavailable on Windows, while the package is published with Windows support. Use the same development-only marker as the other Windows plugins. Fixes firebase#18911
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The stable plugins table still lists Data Connect as N/A on Windows.
firebase_data_connectis published with Windows as a supported platform, and its Firebase dependencies (firebase_core,firebase_auth, andfirebase_app_check) all ship Windows implementations. The other Windows plugins in that table (Authentication, Cloud Firestore, Cloud Storage, Core, and Remote Config) are marked(*): development only, with production unsupported.This changes the Data Connect Windows cell from
N/Ato(*).Related Issues
Fixes #18911
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Test plan
(*)under Windows, and the footnote under the table is unchanged.