Repository navigation
docs(database): mark Windows support as development-only - #18910
Open
Adrianogba wants to merge 1 commit into
Open
Adrianogba wants to merge 1 commit into
Adrianogba wants to merge 1 commit into
Conversation
The README still lists Realtime Database as unavailable on Windows after support shipped in 12.4.0. Use the same development-only marker as the other Windows C++ plugins, and fix the duplicated "Firebase Firebase Database" wording in the plugin README. Fixes firebase#18909
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the main README.md to indicate development-only Windows support for the Realtime Database plugin, and corrects a typo in the firebase_database package's README.md. A review comment suggests adding a terminating period to the corrected sentence in the package's README for punctuation consistency.
| A Flutter plugin to use the [Firebase Database API](https://firebase.google.com/docs/database/). | ||
|
|
||
| To learn more about Firebase Firebase Database, please visit the [Firebase website](https://firebase.google.com/products/realtime-database) | ||
| To learn more about Firebase Realtime Database, please visit the [Firebase website](https://firebase.google.com/products/realtime-database) |
Contributor
There was a problem hiding this comment.
The sentence is missing a terminating period at the end. Adding a period improves punctuation consistency.
Suggested change
| To learn more about Firebase Realtime Database, please visit the [Firebase website](https://firebase.google.com/products/realtime-database) | |
| To learn more about Firebase Realtime Database, please visit the [Firebase website](https://firebase.google.com/products/realtime-database). |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The stable plugins table still lists Realtime Database as N/A on Windows. Windows support shipped in
firebase_database12.4.0 (#18079), and the other Windows C++ plugins in that table (Authentication, Cloud Firestore, Cloud Storage, Core, and Remote Config) are marked(*): development only, with production unsupported.This changes the Realtime Database Windows cell from
N/Ato(*).It also fixes the duplicated product name in the
firebase_databaseREADME, which read "Firebase Firebase Database" instead of "Firebase Realtime Database".Related Issues
Fixes #18909
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]).This will ensure a smooth and quick review process. Updating the
pubspec.yamland changelogs is not required.///).melos run analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?
Test plan
(*)under Windows, and the footnote under the table is unchanged.firebase_databaseREADME reads "To learn more about Firebase Realtime Database, please visit the Firebase website".