Repository navigation
fix(messaging,android): ignore notification events in the messaging receiver #18899
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
akashdh11
wants to merge
1
commit into
firebase:main
Choose a base branch
from
akashdh11:fix/messaging-ignore-dismissed-notifications
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
...test/java/io/flutter/plugins/firebase/messaging/FlutterFirebaseMessagingReceiverTest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -0,0 +1,47 @@ | ||||||
| // Copyright 2026, the Chromium project authors. Please see the AUTHORS file | ||||||
| // for details. All rights reserved. Use of this source code is governed by a | ||||||
| // BSD-style license that can be found in the LICENSE file. | ||||||
|
|
||||||
| package io.flutter.plugins.firebase.messaging; | ||||||
|
|
||||||
| import static org.junit.Assert.assertFalse; | ||||||
| import static org.junit.Assert.assertTrue; | ||||||
|
|
||||||
| import android.content.Intent; | ||||||
| import android.os.Bundle; | ||||||
| import android.os.Parcelable; | ||||||
| import org.junit.Test; | ||||||
|
|
||||||
| public class FlutterFirebaseMessagingReceiverTest { | ||||||
| // A broadcast whose "wrapped_intent" extra is `wrapped`. The android.jar of unit tests keeps no | ||||||
| // extras, so the broadcast answers the one the receiver reads itself. | ||||||
| private static Intent broadcastWrapping(final Parcelable wrapped) { | ||||||
| return new Intent() { | ||||||
| @Override | ||||||
| @SuppressWarnings({"deprecation", "unchecked"}) | ||||||
| public <T extends Parcelable> T getParcelableExtra(String name) { | ||||||
| return "wrapped_intent".equals(name) ? (T) wrapped : null; | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Reuse the package-private constant
Suggested change
|
||||||
| } | ||||||
| }; | ||||||
| } | ||||||
|
|
||||||
| @Test | ||||||
| public void aDismissedNotificationIsANotificationEvent() { | ||||||
| // What firebase-messaging broadcasts when the user dismisses a notification it displayed. | ||||||
| Intent dismissal = | ||||||
| broadcastWrapping(new Intent("com.google.firebase.messaging.NOTIFICATION_DISMISS")); | ||||||
|
|
||||||
| assertTrue(FlutterFirebaseMessagingReceiver.isNotificationEvent(dismissal)); | ||||||
| } | ||||||
|
|
||||||
| @Test | ||||||
| public void aMessageIsNotANotificationEvent() { | ||||||
| assertFalse(FlutterFirebaseMessagingReceiver.isNotificationEvent(broadcastWrapping(null))); | ||||||
| } | ||||||
|
|
||||||
| @Test | ||||||
| public void aWrappedExtraThatIsNotAnIntentIsNotANotificationEvent() { | ||||||
| assertFalse( | ||||||
| FlutterFirebaseMessagingReceiver.isNotificationEvent(broadcastWrapping(new Bundle()))); | ||||||
| } | ||||||
| } | ||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The constant
EXTRA_WRAPPED_INTENTcan be made package-private (by removing theprivatemodifier) so that it can be reused in the corresponding unit testFlutterFirebaseMessagingReceiverTestinstead of hardcoding the string literal"wrapped_intent"there.