Repository navigation
chore(firestore): use precompiled Firestore frameworks again in 4.x example Podfiles - #18865
Merged
Merged
Conversation
…xample Podfiles invertase/firestore-ios-sdk-frameworks now has a 12.19.3 tag, and FirebaseFirestoreBinary/FirebaseFirestoreInternalBinary 12.19.3 are on CocoaPods trunk.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds the FirebaseFirestore pod dependency to both the iOS and macOS Podfiles. The reviewer suggests removing redundant string interpolation when passing the firebase_sdk_version variable to the :tag option, as the variable is already a string.
| end | ||
| end | ||
|
|
||
| pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => "#{firebase_sdk_version}" |
Contributor
There was a problem hiding this comment.
The variable firebase_sdk_version is already a string. You can pass it directly to the :tag option instead of using redundant string interpolation.
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => firebase_sdk_version
| end | ||
| end | ||
|
|
||
| pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => "#{firebase_sdk_version}" |
Contributor
There was a problem hiding this comment.
The variable firebase_sdk_version is already a string. You can pass it directly to the :tag option instead of using redundant string interpolation.
pod 'FirebaseFirestore', :git => 'https://github.com/invertase/firestore-ios-sdk-frameworks.git', :tag => firebase_sdk_version
SelaseKay
approved these changes
Oct 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Restores the
invertase/firestore-ios-sdk-frameworksoverride in the 4.x Firestore example Podfiles (iOS and macOS). It was dropped in #18861 because the repo had no12.19.3tag.That's now published:
12.19.3and its GitHub releaseFirebaseFirestoreBinaryandFirebaseFirestoreInternalBinary12.19.3 on CocoaPods trunk (after fix: allow patch-skipped Firebase pods in FirebaseFirestoreBinary invertase/firestore-ios-sdk-frameworks#131 fixed the binary podspec for the partial 12.19.3 release)The Firestore iOS and macOS e2e jobs on this PR run
pod installagainst that tag, so they also verify the precompiled release end to end.Example apps only; no package or release change.
Breaking Change