Repository navigation
fix(apple): resolve CocoaPods deps that skip the 12.19.3 patch release - #18862
Merged
Merged
Conversation
Firebase 12.19.3 only ships Core, Firestore and the umbrella pod. firebase_app_check (iOS) now depends on Firebase/AppCheck like macOS, and firebase_analytics allows any 12.19.x FirebaseAnalytics.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the dependency configurations in the iOS and macOS podspecs. Specifically, it modifies firebase_analytics to allow any patch of the minor version and corrects the firebase_app_check dependency name to Firebase/AppCheck. Feedback on the changes highlights a potential issue where the regex replacement used to strip the patch version in firebase_analytics could fail on pre-release version strings (e.g., 12.19.3-beta.1). A more robust string manipulation approach using split and join is recommended to safely target the correct minor version.
…ithout a regex Pre-release or two-part $FirebaseSDKVersion overrides (12.19.3-beta.1, 12.19) now resolve to ~> 12.19.0 instead of ~> 12.19.3-beta.0 / ~> 12.0.
Lyokone
marked this pull request as ready for review
October 23, 2026 10:01
SelaseKay
approved these changes
Oct 23, 2026
demolaf
approved these changes
Oct 23, 2026
|
thanks for the fix! is a patch release with this change planned soon? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #18856, which pinned CocoaPods to Firebase
12.19.3(Firestore root-certificate security fix, firebase/firebase-ios-sdk#16930).12.19.3is a partial release: on CocoaPods onlyFirebase,FirebaseCore,FirebaseFirestoreandFirebaseFirestoreInternalwere published, and the umbrella's other subspecs depend on~> 12.19.0. Two plugins pinned standalone pods to the exact SDK version, sopod installfails:firebase_app_check(iOS):FirebaseAppCheck ~> 12.19.3→Firebase/AppCheck(matches macOS)firebase_analytics(iOS + macOS):FirebaseAnalytics = 12.19.3→~> 12.19.0, built from the first two components offirebase_sdk_versionso pre-release or two-part$FirebaseSDKVersionoverrides also give~> 12.19.0No other podspec depends on a standalone
Firebase*pod atfirebase_sdk_version. Same fix as the 4.x backport #18861.Breaking Change