Skip to content

fix(firebase_database_web): point DataSnapshot.child() ref at the child - #18822

Merged
Lyokone merged 1 commit into
mainfrom
fix/database-web-child-ref
Oct 21, 2026
Merged

Lyokone merged 1 commit into
mainfrom
fix/database-web-child-ref

Conversation

@Lyokone

@Lyokone Lyokone commented Oct 20, 2026

Copy link
Copy Markdown
Contributor

Description

DataSnapshotWeb.child(path) passed the parent ref to the child snapshot. On web, snapshot.child('a').ref pointed at the parent, so snapshot.child('a').ref.set(x) overwrote the parent. The child snapshot now uses ref.child(path), like children already does. Native platforms are not affected.

Testing

  • firebase_database_web/test/data_snapshot_web_test.dart (new, Chrome), using a stand-in for the JS DataSnapshot. Fails on main (Expected: 'messages/a', Actual: 'messages').
  • This is the package's first test folder, so melos run test:web picks it up.
  • dart analyze --fatal-infos is clean.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

`DataSnapshot.child(path)` reused the parent reference, so
`snapshot.child('a').ref.set(x)` overwrote the parent on web. The child
snapshot now uses `ref.child(path)`, as `children` already did.
@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone merged commit 63e8560 into main Oct 21, 2026
39 checks passed
@Lyokone
Lyokone deleted the fix/database-web-child-ref branch October 21, 2026 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants