Skip to content

fix(core, crashlytics): drop flutter_test from published dependencies - #18575

Merged
Lyokone merged 1 commit into
mainfrom
fix/17001
Aug 20, 2026
Merged

Lyokone merged 1 commit into
mainfrom
fix/17001

Conversation

@Lyokone

@Lyokone Lyokone commented Aug 18, 2026 •

Copy link
Copy Markdown
Contributor

Description

  • firebase_core_platform_interface and firebase_crashlytics_platform_interface declared flutter_test as a regular dependency, which pins test_api for every consumer and breaks version solving for apps that also use package:test. It is now a dev dependency: the Pigeon test API shipped in lib/ imports a small test_binding.dart shim instead, melos run generate:pigeon rewrites the generated import, and scripts/validate_workspace.dart fails if a published package declares flutter_test again.
  • Drive-by: that script's package walk no longer follows symlinks and prunes ignored directories as it descends, so it stops cycling through the CocoaPods .symlinks directories in example apps and actually completes when run locally.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@wiz-9635d3485b

wiz-9635d3485b Bot commented Aug 18, 2026 •

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
SAST Finding SAST Findings -
Software Management Finding Software Management Findings -
Total -

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio.

@Lyokone
Lyokone changed the base branch from master to main August 18, 2026 13:34
`firebase_core_platform_interface` declared `flutter_test` as a regular
dependency, which pins `test_api` for every consumer and breaks version
solving for apps that also depend on `package:test`.
`firebase_crashlytics_platform_interface` picked up the same dependency
with its Pigeon migration.

The dependency existed because Pigeon emits its test API into `lib/`, so
other packages can mock the host APIs, and a file in `lib/` cannot import
a dev dependency. Add a `test_binding.dart` shim that exposes the two
members the generated test APIs use, reaching the test binary messenger
through `ServicesBinding` instead, and rewrite the generated import to it
as part of `melos run generate:pigeon`.

`scripts/validate_workspace.dart` now fails if a published package
declares `flutter_test` under `dependencies`, so this cannot regress. Its
package walk also no longer follows symlinks and prunes ignored
directories as it descends, so it stops cycling through the CocoaPods
`.symlinks` directories in example apps and completes locally.

Fixes #17001
@Lyokone
Lyokone merged commit a54439f into main Aug 20, 2026
111 checks passed
@Lyokone
Lyokone deleted the fix/17001 branch August 20, 2026 08:01
@firebase firebase locked and limited conversation to collaborators Sep 19, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[firebase_core_platform_interface] Direct non-dev dependency on flutter_test causing dependency resolution issues

3 participants