Repository navigation
Conversation
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. |
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try the Wiz Code extension for VS Code, JetBrains, or Visual Studio. |
`firebase_core_platform_interface` declared `flutter_test` as a regular dependency, which pins `test_api` for every consumer and breaks version solving for apps that also depend on `package:test`. `firebase_crashlytics_platform_interface` picked up the same dependency with its Pigeon migration. The dependency existed because Pigeon emits its test API into `lib/`, so other packages can mock the host APIs, and a file in `lib/` cannot import a dev dependency. Add a `test_binding.dart` shim that exposes the two members the generated test APIs use, reaching the test binary messenger through `ServicesBinding` instead, and rewrite the generated import to it as part of `melos run generate:pigeon`. `scripts/validate_workspace.dart` now fails if a published package declares `flutter_test` under `dependencies`, so this cannot regress. Its package walk also no longer follows symlinks and prunes ignored directories as it descends, so it stops cycling through the CocoaPods `.symlinks` directories in example apps and completes locally. Fixes #17001
Description
firebase_core_platform_interfaceandfirebase_crashlytics_platform_interfacedeclaredflutter_testas a regular dependency, which pinstest_apifor every consumer and breaks version solving for apps that also usepackage:test. It is now a dev dependency: the Pigeon test API shipped inlib/imports a smalltest_binding.dartshim instead,melos run generate:pigeonrewrites the generated import, andscripts/validate_workspace.dartfails if a published package declaresflutter_testagain..symlinksdirectories in example apps and actually completes when run locally.Related Issues
flutter_testcausing dependency resolution issues #17001Checklist
///).melos run analyze) does not report any problems on my PR.Breaking Change