Skip to content

test(auth,database,functions): move e2e suites into their example apps - #18541

Merged
Lyokone merged 2 commits into
ci/p2-remove-dead-testsfrom
ci/p2-migrate-auth-db-functions
Aug 6, 2026
Merged

Lyokone merged 2 commits into
ci/p2-remove-dead-testsfrom
ci/p2-migrate-auth-db-functions

Conversation

@Lyokone

@Lyokone Lyokone commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

Description

Replace this paragraph with a description of what this PR is doing. If you're modifying existing behavior, describe the existing behavior, how this PR is changing it, and what motivated the change.

Related Issues

Replace this paragraph with a list of issues related to this PR from the issue database. Indicate, which of these issues are resolved or fixed by this PR. Note that you'll have to prefix the issue numbers with flutter/flutter#.

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@Lyokone
Lyokone force-pushed the ci/p2-migrate-auth-db-functions branch from dff396d to 76c3b20 Compare August 5, 2026 12:19
@Lyokone
Lyokone force-pushed the ci/p2-migrate-auth-db-functions branch from 76c3b20 to 4127bd3 Compare August 5, 2026 12:20
Lyokone added 2 commits August 5, 2026 14:22
Second wave of per-product e2e migrations on the storage template. Each
product gets a path-filtered, platform-scoped workflow (a Kotlin-only
change runs android only), its own emulator per job, and builds linking
only its own native deps instead of the mega-app's ~26.

- auth: 5 files, windows coverage preserved (it had it in the mega-app
  windows run); iOS stays CocoaPods because flutter_facebook_auth
  ^7.1.5 currently resolves to 7.1.6 which ships no Package.swift -
  CocoaPods is correct under either resolution; flip to SPM when the
  constraint moves to ^7.2.0
- database: 8 files including the conditional web_only import pair; iOS
  runs SPM (all deps ship Package.swift); no windows job (never had
  coverage, example has no windows/)
- functions: 2 files; iOS runs SPM; no windows job
- generator: --auth-native/--database-native/--functions-native;
  database needed a separate macOS bundle id (differs from iOS)
- mega-app: auth + database_functions shards and matrix legs removed;
  only core_misc remains; tests/pubspec.yaml untouched (coexistence)
- nightly + dashboard wired for the three new workflows
… SPM

7.2.0 is the first release shipping a Package.swift; with it every
plugin in the example resolves under Swift Package Manager, so the iOS
job moves off CocoaPods (macOS keeps it - both managers stay covered).
@Lyokone
Lyokone force-pushed the ci/p2-migrate-auth-db-functions branch from 4127bd3 to 3dd30df Compare August 5, 2026 12:22
@Lyokone
Lyokone marked this pull request as ready for review August 5, 2026 13:09
@Lyokone
Lyokone merged commit 041af59 into main Aug 6, 2026
57 of 69 checks passed
@Lyokone
Lyokone deleted the ci/p2-migrate-auth-db-functions branch August 6, 2026 12:33
@firebase firebase locked and limited conversation to collaborators Sep 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants