Skip to content

refactor(messaging, web): convert classes to extension types for improved interop #17820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −35
Open

refactor(messaging, web): convert classes to extension types for improved interop #17820

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ca8eb23
fix(messaging): convert classes to extension types for improved interop
SelaseKay Oct 28, 2025
95c0bb6
fix(messaging): remove unnecessary JS annotation for Messaging extens…
SelaseKay Oct 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 6 additions & 34 deletions packages/firebase_messaging/firebase_messaging_web/lib/src/interop/messaging_interop.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,54 +37,31 @@ external JSFunction onMessage(
);

@JS('Messaging')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can delete this line

@staticInterop
abstract class MessagingJsImpl {}
extension type MessagingJsImpl._(JSObject _) implements JSObject {}

@JS()
@staticInterop
@anonymous
class Observer {
extension type Observer._(JSObject _) implements JSObject {
external factory Observer({JSAny next, JSAny error});
}

extension ObserverJsImplX on Observer {
external JSAny get next;
external JSAny get error;
}

@JS()
@staticInterop
@anonymous
class GetTokenOptions {
extension type GetTokenOptions._(JSObject _) implements JSObject {
// TODO - I imagine we won't be implementing serviceWorkerRegistration type as it extends EventTarget class
// external String get serviceWorkerRegistration
external factory GetTokenOptions({
JSString? vapidKey,
/*dynamic serviceWorkerRegistration */
});
}

extension GetTokenOptionsJsImplX on GetTokenOptions {
external JSString get vapidKey;
}

@JS()
@staticInterop
@anonymous
abstract class NotificationPayloadJsImpl {}

extension NotificationPayloadJsImplX on NotificationPayloadJsImpl {
extension type NotificationPayloadJsImpl._(JSObject _) implements JSObject {
external JSString? get title;
external JSString? get body;
external JSString? get image;
}

@JS()
@staticInterop
@anonymous
abstract class MessagePayloadJsImpl {}

extension MessagePayloadJsImplX on MessagePayloadJsImpl {
extension type MessagePayloadJsImpl._(JSObject _) implements JSObject {
external JSString get messageId;
external JSString? get collapseKey;
external FcmOptionsJsImpl? get fcmOptions;
Expand All @@ -93,12 +70,7 @@ extension MessagePayloadJsImplX on MessagePayloadJsImpl {
external JSString? get from;
}

@JS()
@staticInterop
@anonymous
abstract class FcmOptionsJsImpl {}

extension FcmOptionsJsImplX on FcmOptionsJsImpl {
extension type FcmOptionsJsImpl._(JSObject _) implements JSObject {
external JSString? get analyticsLabel;
external JSString? get link;
}
Loading