Skip to content

fix(analytics, iOS): Update hashedPhoneNumber handling to use hex string conversion #17807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(analytics, iOS): Update hashedPhoneNumber handling to use hex string conversion #17807

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3913dd1
fix(analytics, iOS): Update hashedPhoneNumber handling to use hex str…
SelaseKay Oct 22, 2025
64614b6
refactor: Replace Data extension with a dedicated hex string conversi…
SelaseKay Oct 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 20 additions & 1 deletion ...analytics/ios/firebase_analytics/Sources/firebase_analytics/FirebaseAnalyticsPlugin.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,12 +136,31 @@ public class FirebaseAnalyticsPlugin: NSObject, FLTFirebasePluginProtocol, Flutt
Analytics.initiateOnDeviceConversionMeasurement(hashedEmailAddress: data)
}
if let hashedPhoneNumber = arguments["hashedPhoneNumber"] as? String,
let data = hashedPhoneNumber.data(using: .utf8) {
let data = hexStringToData(hashedPhoneNumber) {
Analytics.initiateOnDeviceConversionMeasurement(hashedPhoneNumber: data)
}
completion(.success(()))
}

private func hexStringToData(_ hexString: String) -> Data? {
let length = hexString.count
guard length % 2 == 0 else { return nil }

var data = Data(capacity: length / 2)
var index = hexString.startIndex

for _ in 0 ..< (length / 2) {
let nextIndex = hexString.index(index, offsetBy: 2)
guard let byte = UInt8(hexString[index ..< nextIndex], radix: 16) else {
return nil
}
data.append(byte)
index = nextIndex
}

return data
}

public func didReinitializeFirebaseCore(_ completion: @escaping () -> Void) {
completion()
}
Expand Down
Loading