Skip to content

fix(messaging, android): use only one FlutterLoader instance #12845

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 31, 2024

Conversation

russellwheatley
Copy link
Member

Description

This method stops these warning logs from popping up when running the app:

W/FlutterJNI( 5559): FlutterJNI.loadLibrary called more than once
W/FlutterJNI( 5559): FlutterJNI.prefetchDefaultFontManager called more than once

This method was used as a fix here for this very reason.

Also used by local flutter notifications

Even in the Flutter engine itself.

Related Issues

fixes #9964

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@russellwheatley russellwheatley merged commit 40966c7 into master May 31, 2024
22 of 23 checks passed
@russellwheatley russellwheatley deleted the messaging-9964 branch May 31, 2024 08:42
@firebase firebase locked and limited conversation to collaborators Jul 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FlutterJNI.loadLibrary called more than once
3 participants