Update FTL GHA version & other minor fixes (#494)

Author: sunmou99

.github/workflows/integration_tests.yml

@@ -159,6 +159,7 @@ jobs:
     name: build-${{ matrix.unity_version }}-${{matrix.os}}-${{ matrix.platform }}-${{ matrix.ios_sdk }}
     runs-on: ${{matrix.os}}
     needs: check_and_prepare
+    if: ${{ needs.check_and_prepare.outputs.build_matrix != '' && !cancelled() }}
     strategy:
       fail-fast: false
       matrix: ${{ fromJson(needs.check_and_prepare.outputs.build_matrix) }}
@@ -283,57 +284,57 @@ jobs:
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Upload Android integration tests artifact
         uses: actions/upload-artifact@v3
-        if: contains(matrix.platform, 'Android') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Android') && !cancelled() }}
         with:
           name: testapps-Android-${{ steps.matrix_info.outputs.artifact_suffix }}
           path: testapps-${{ steps.matrix_info.outputs.info }}/Android
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Delete Android integration tests artifact
-        if: contains(matrix.platform, 'Android') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Android') && !cancelled() }}
         shell: bash
         run: rm -rf testapps-${{ steps.matrix_info.outputs.info }}/Android || true
       - name: Upload iOS integration tests artifact
         uses: actions/upload-artifact@v3
-        if: contains(matrix.platform, 'iOS') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'iOS') && !cancelled() }}
         with:
           name: testapps-iOS-${{ steps.matrix_info.outputs.artifact_suffix }}
           path: testapps-${{ steps.matrix_info.outputs.info }}/iOS
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Delete iOS integration tests artifact
-        if: contains(matrix.platform, 'iOS') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'iOS') && !cancelled() }}
         shell: bash
         run: rm -rf testapps-${{ steps.matrix_info.outputs.info }}/iOS || true
       - name: Upload Linux integration tests artifact
         uses: actions/upload-artifact@v3
-        if: contains(matrix.platform, 'Linux') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Linux') && !cancelled() }}
         with:
           name: testapps-Linux-${{ steps.matrix_info.outputs.artifact_suffix }}
           path: testapps-${{ steps.matrix_info.outputs.info }}/Linux
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Delete Linux integration tests artifact
-        if: contains(matrix.platform, 'Linux') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Linux') && !cancelled() }}
         shell: bash
         run: rm -rf testapps-${{ steps.matrix_info.outputs.info }}/Linux || true
       - name: Upload macOS integration tests artifact
         uses: actions/upload-artifact@v3
-        if: contains(matrix.platform, 'macOS') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'macOS') && !cancelled() }}
         with:
           name: testapps-macOS-${{ steps.matrix_info.outputs.artifact_suffix }}
           path: testapps-${{ steps.matrix_info.outputs.info }}/macOS
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Delete macOS integration tests artifact
-        if: contains(matrix.platform, 'macOS') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'macOS') && !cancelled() }}
         shell: bash
         run: rm -rf testapps-${{ steps.matrix_info.outputs.info }}/macOS || true
       - name: Upload Windows integration tests artifact
         uses: actions/upload-artifact@v3
-        if: contains(matrix.platform, 'Windows') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Windows') && !cancelled() }}
         with:
           name: testapps-Windows-${{ steps.matrix_info.outputs.artifact_suffix }}
           path: testapps-${{ steps.matrix_info.outputs.info }}/Windows
           retention-days: ${{ env.artifactRetentionDays }}
       - name: Delete Windows integration tests artifact
-        if: contains(matrix.platform, 'Windows') && ${{ !cancelled() }}
+        if: ${{ contains(matrix.platform, 'Windows') && !cancelled() }}
         shell: bash
         run: rm -rf testapps-${{ steps.matrix_info.outputs.info }}/Windows || true
       - name: Download log artifacts
@@ -365,6 +366,7 @@ jobs:
     name: test-${{ matrix.unity_version }}-${{matrix.os}}-Playmode
     runs-on: ${{matrix.os}}
     needs: check_and_prepare
+    if: ${{ needs.check_and_prepare.outputs.playmode_matrix != '' && !cancelled() }}
     strategy:
       fail-fast: false
       matrix: ${{ fromJson(needs.check_and_prepare.outputs.playmode_matrix) }}
@@ -499,7 +501,7 @@ jobs:
   integration_test:
     name: test-${{ matrix.unity_version }}-${{matrix.build_os}}-${{ matrix.platform }}-${{ matrix.test_device }}-${{ matrix.test_os }}
     runs-on: ${{ matrix.test_os }}
-    if: ${{ !cancelled() }}
+    if: ${{ needs.check_and_prepare.outputs.build_matrix != '' && needs.check_and_prepare.outputs.test_matrix != '' && !cancelled() }}
     needs: [check_and_prepare, build_testapp]
     strategy:
       fail-fast: false
@@ -535,7 +537,7 @@ jobs:
       - name: Run Mobile integration tests on real device via FTL
         id: ftl_test
         if: ${{ matrix.device_type == 'real' }}
-        uses: FirebaseExtended/github-actions/firebase-test-lab@v1.1
+        uses: FirebaseExtended/github-actions/firebase-test-lab@v1.2
         with:
           credentials_json: ${{ secrets.FIREBASE_SERVICE_ACCOUNT_CREDENTIALS }}
           testapp_dir: testapps

scripts/gha/print_matrix_configuration.py

@@ -268,6 +268,8 @@ def get_testapp_build_matrix(matrix_type, unity_versions, platforms, build_os, i
 
   # generate base matrix: combinations of (unity_versions, platforms, build_os)
   l = list(itertools.product(unity_versions, platforms, build_os))
+  if not l: return ""
+
   matrix = {"include": []}
   for li in l:
     unity_version = li[0]
@@ -320,11 +322,14 @@ def get_testapp_test_matrix(matrix_type, unity_versions, platforms, build_os, mo
 
   if matrix_type: unity_versions = get_value("integration_tests", matrix_type, "unity_versions")
   if matrix_type: platforms = get_value("integration_tests", matrix_type, "platforms")
+  if PLAYMODE in platforms: platforms.remove(PLAYMODE)
   if matrix_type: build_os = get_value("integration_tests", matrix_type, "build_os")
   if matrix_type: mobile_device_types = get_value("integration_tests", matrix_type, "mobile_test_on")
 
   # generate base matrix: combinations of (unity_versions, platforms, build_os)
   l = list(itertools.product(unity_versions, platforms, build_os))
+  if not l: return ""
+
   matrix = {"include": []}
   for li in l:
     unity_version = li[0]
@@ -333,11 +338,12 @@ def get_testapp_test_matrix(matrix_type, unity_versions, platforms, build_os, mo
 
     if platform in [WINDOWS, MACOS, LINUX]:
       test_os = _get_test_os(platform)
-      matrix["include"].append({"unity_version": unity_version, "platform": platform, "build_os": build_os, "test_os": test_os, "test_device": "github_runner", "ios_sdk": "NA"})
+      matrix["include"].append({"unity_version": unity_version, "platform": platform, "build_os": build_os, "test_os": test_os, "test_device": "github_runner", "device_detail": "NA", "device_type": "NA", "ios_sdk": "NA"})
     else:
       mobile_devices = get_value("integration_tests", matrix_type, "mobile_devices")
       for mobile_device in mobile_devices:
         device_detail = TEST_DEVICES.get(mobile_device).get("device")
+        if not device_detail: device_detail = "NA"
         device_type = TEST_DEVICES.get(mobile_device).get("type")
         device_platform = TEST_DEVICES.get(mobile_device).get("platform")
         if device_platform == platform and device_type in mobile_device_types: