Skip to content

Commit 60f1f0e

Browse files
authored
Turn on always link for Crashlytics (#505)
1 parent facb46b commit 60f1f0e

File tree

7 files changed

+9
-34
lines changed

7 files changed

+9
-34
lines changed

crashlytics/CMakeLists.txt

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -106,12 +106,6 @@ endif()
106106

107107
unity_pack_cs(firebase_crashlytics_cs)
108108

109-
# Crashlytics has a special file to prevent il2cpp from stripping symbols.
110-
unity_pack_file(
111-
"link.xml"
112-
PACK_PATH "Firebase/Plugins/Crashlytics"
113-
)
114-
115109
if (FIREBASE_INCLUDE_UNITY)
116110
generate_dependencies_xml(Crashlytics
117111
IOS_DEPS

crashlytics/link.xml

Lines changed: 0 additions & 5 deletions
This file was deleted.

crashlytics/src/Crashlytics.cs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,10 @@
1414
* limitations under the License.
1515
*/
1616

17+
// Always link the Crashlytics assembly, since it tends to be stripped,
18+
// and a valid use case doesn't require the user to use the class directly.
19+
[assembly: UnityEngine.Scripting.AlwaysLinkAssembly]
20+
1721
namespace Firebase.Crashlytics {
1822
using System;
1923
using System.Diagnostics;

crashlytics/src/Metadata.cs

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,6 @@
1515
*/
1616

1717
namespace Firebase.Crashlytics {
18-
using System;
1918
using System;
2019
using UnityEngine;
2120

docs/readme.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -67,6 +67,11 @@ Support
6767

6868
Release Notes
6969
-------------
70+
### Upcoming
71+
- Changes
72+
- Crashlytics (Android): Fixed an [issue](https://github.com/firebase/quickstart-unity/issues/1116)
73+
with symbols being stripped when using the tgz package.
74+
7075
### 10.0.1
7176
- Changes
7277
- Crashlytics (Android): Fixed a critical [issue](https://github.com/firebase/firebase-android-sdk/issues/4223)

unity_packer/debug_single_export_json/crashlytics.json

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -278,20 +278,6 @@
278278
}
279279
}
280280
},
281-
{
282-
"importer": "PluginImporter",
283-
"platforms": [
284-
"Editor",
285-
"Standalone",
286-
"Android",
287-
"iOS",
288-
"tvOS"
289-
],
290-
"cpu": "AnyCPU",
291-
"paths": [
292-
"Firebase/Plugins/Crashlytics/link.xml"
293-
]
294-
},
295281
{
296282
"importer": "DefaultImporter",
297283
"paths": [

unity_packer/exports.json

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -433,14 +433,6 @@
433433
}
434434
}
435435
},
436-
{
437-
"importer": "PluginImporter",
438-
"platforms": ["Editor", "Standalone", "Android", "iOS", "tvOS"],
439-
"cpu": "AnyCPU",
440-
"paths": [
441-
"Firebase/Plugins/Crashlytics/link.xml"
442-
]
443-
},
444436
{
445437
"importer": "DefaultImporter",
446438
"paths": [

0 commit comments

Comments
 (0)