initial apphosting mcp tool #8605
Open
+182
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joehan
approved these changes
May 15, 2025
| if (!projectId) return NO_PROJECT_ERROR; | ||
| if (!location) location = "-"; | ||
| const data: (Backend & { traffic: Traffic })[] = []; | ||
| const backends = await listBackends(projectId, location); |
There was a problem hiding this comment.
We might want a different message for no backends - ie
Suggested change
| const backends = await listBackends(projectId, location); | |
| const backends = await listBackends(projectId, location); | |
| if (!backends.length) return toContent("No backends exist on project ${projectId} ${location !== "-" ? `in ${location}` :""} |
Not sure what the LLMs will like more
github-project-automation
bot
moved this to Approved [PR]
in [Cloud] Extensions + Functions
fredzqm
reviewed
May 15, 2025
| }, | ||
| }, | ||
| async ({ location } = {}, { projectId }) => { | ||
| if (!projectId) return NO_PROJECT_ERROR; |
There was a problem hiding this comment.
This is already taken care of by the caller.
firebase-tools/src/mcp/index.ts
Line 189 in 214d190
There was a problem hiding this comment.
Sure, but I still have to assert that projectId isn't undefined, otherwise I have to do checks all over the place. Does this hurt that much to bother?
There was a problem hiding this comment.
Yeah, it's a bit annoying that projectId is nullable even if requiresProject is true above.
Maybe we can do a clean up to supply a dummy projectId: "missing-project" if there there is no project present.
fredzqm
reviewed
May 15, 2025
fredzqm
approved these changes
May 15, 2025
github-project-automation
bot
moved this from Approved [PR]
to Changes Requested [PR]
in [Cloud] Extensions + Functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an initial MCP tool for App Hosting.
This combines the Backend and it's singleton Traffic resource into one so that the LLM can make some inferences about the traffic information!
Scenarios Tested
Sample Commands