Skip to content

Conversation

@MarkDuckworth
Copy link
Contributor

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

  • Read the contribution guidelines (CONTRIBUTING.md).
  • If this has been discussed in an issue, make sure to link to the issue here.
    If not, go file an issue about this before creating a pull request to discuss.

Testing

  • Make sure all existing tests in the repository pass after your change.
  • If you fixed a bug or added a feature, add a new test to cover your code.

API Changes

  • At this time we cannot accept changes that affect the public API. If you'd like to help
    us make Firebase APIs better, please propose your change in an issue so that we
    can discuss it together.

MarkDuckworth and others added 30 commits October 14, 2024 08:25
* Skip pipeline tests in lite, for now

* update bundle definitions for size report

* Fix size testing for pipelines bundles

* fixed typings

* Fixed package paths

* Fix integration tests that run on the built packages
* dist/firestore/src/global_index.d.ts now includes pipelines in namespace 'pipelines'

* Update global.ts

* Custom replacer plugin to remove declare module block from global.d.ts

* Update CDN and g3 builds of Firestore to include Pipelines in the firebase-firestore.js file

* Updated CDN bundles so that firebase-firestore.js is not modified, but firebase-firestore-pipelines.js contains both classic and pipelines APIs.

* Fix regression in _internalPipelineToExecutePipelineRequestProto

* Fixing missing paths in package.json

* Fix binary size script

* Add support for index.cdn.ts files in packages/firebase. Then added a cdn.ts to packages/firebase/firestore/pipelines

* Rename grpc_connection.node.test.ts, so the file is filtered from browser unit testing.
* clean up exports and imports

* Fix implementation of Query to Pipeline for isNan, isNotNan, isNull, and isNotNull changes in the backend

* fix tests to accomodate for backend changes to multiple sort stages

* another test that the console usage will perform runtime validation of user data

* formatting

* Copy the latest pipelines tests into lite api pipelines tests. Fix a few minor bugs in the lite pipeline implementation

* Remove special handling of null and nan in query to pipeline

* remove function expresssions isNan, isNull, isNotNan, isNotNull, and error

* Renamed len function to length, with a fix to the prune-dts script

* lastest API review md files

* fixed title is not null test
@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2025

⚠️ No Changeset found

Latest commit: f9c4cde

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 29, 2025

Size Report 1

Affected Products

  • @firebase/firestore

    TypeBase (c47bd71)Merge (b9521af)Diff
    browser391 kB393 kB+1.47 kB (+0.4%)
    main611 kB636 kB+25.6 kB (+4.2%)
    module391 kB393 kB+1.47 kB (+0.4%)
    react-native392 kB393 kB+1.40 kB (+0.4%)
  • @firebase/firestore-lite

    TypeBase (c47bd71)Merge (b9521af)Diff
    browser115 kB118 kB+2.59 kB (+2.2%)
    main158 kB169 kB+10.4 kB (+6.6%)
    module115 kB118 kB+2.59 kB (+2.2%)
    react-native116 kB118 kB+2.58 kB (+2.2%)
  • @firebase/firestore-lite-pipelines

    TypeBase (c47bd71)Merge (b9521af)Diff
    browser?111 kB? (?)
    main?211 kB? (?)
    module?111 kB? (?)
    react-native?111 kB? (?)
  • @firebase/firestore-pipelines

    TypeBase (c47bd71)Merge (b9521af)Diff
    browser?203 kB? (?)
    main?630 kB? (?)
    module?203 kB? (?)
    react-native?203 kB? (?)
  • bundle

    18 size changes

    TypeBase (c47bd71)Merge (b9521af)Diff
    firestore (CSI Auto Indexing Disable and Delete)286 kB287 kB+556 B (+0.2%)
    firestore (CSI Auto Indexing Enable)286 kB287 kB+556 B (+0.2%)
    firestore (Persistence)318 kB318 kB+536 B (+0.2%)
    firestore (Pipeline Query with lt filter (execute))?245 kB? (?)
    firestore (Pipeline Query with lt filter (useFirestorePipelines))?170 kB? (?)
    firestore (Pipeline Query with lt plus and function)?170 kB? (?)
    firestore (Query Cursors)257 kB258 kB+1.07 kB (+0.4%)
    firestore (Query)255 kB256 kB+1.09 kB (+0.4%)
    firestore (Read data once)245 kB245 kB+434 B (+0.2%)
    firestore (Read Write w Persistence)338 kB338 kB+935 B (+0.3%)
    firestore (Realtime updates)245 kB245 kB+443 B (+0.2%)
    firestore (Transaction)223 kB224 kB+997 B (+0.4%)
    firestore (Write data)224 kB225 kB+901 B (+0.4%)
    firestore-lite (Query Cursors)110 kB112 kB+2.33 kB (+2.1%)
    firestore-lite (Query)106 kB108 kB+2.19 kB (+2.1%)
    firestore-lite (Read data once)81.6 kB83.0 kB+1.35 kB (+1.7%)
    firestore-lite (Transaction)107 kB109 kB+2.14 kB (+2.0%)
    firestore-lite (Write data)91.1 kB93.0 kB+1.93 kB (+2.1%)

  • firebase

    TypeBase (c47bd71)Merge (b9521af)Diff
    firebase-compat.js809 kB810 kB+1.08 kB (+0.1%)
    firebase-firestore-compat.js348 kB349 kB+1.08 kB (+0.3%)
    firebase-firestore-lite-pipelines.js?122 kB? (?)
    firebase-firestore-lite.js138 kB139 kB+665 B (+0.5%)
    firebase-firestore-pipelines.js?505 kB? (?)
    firebase-firestore.js454 kB455 kB+982 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Dof52OV7BK.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 29, 2025

Size Analysis Report 1

This report is too large (1,066,258 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/Z9acJA19i0.html

@MarkDuckworth MarkDuckworth changed the title Feat/pipelines feat/pipelines to main Nov 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants