Skip to content

Fixed onComplete for FDC #9349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Oct 30, 2025
Merged

Fixed onComplete for FDC #9349

merged 8 commits into from
Oct 30, 2025

Conversation

@maneesht
Copy link
Contributor

@maneesht maneesht commented Oct 27, 2025

Hey there! So you want to contribute to a Firebase SDK?
Before you file this pull request, please read these guidelines:

Discussion

Testing

  • Added extra unit test

API Changes

  • No API changes

@maneesht maneesht requested review from a team and aashishpatil-g as code owners October 27, 2025 21:11
@changeset-bot
Copy link

changeset-bot bot commented Oct 27, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d73cb4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@firebase/data-connect Patch
firebase Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@maneesht maneesht requested review from a team as code owners October 27, 2025 21:13
@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2025 •
edited
Loading

Size Report 1

Affected Products

  • @firebase/ai

    TypeBase (8209266)Merge (dc82866)Diff
    browser65.1 kB65.4 kB+240 B (+0.4%)
    main69.0 kB69.2 kB+240 B (+0.3%)
    module65.1 kB65.4 kB+240 B (+0.4%)

  • @firebase/data-connect

    TypeBase (8209266)Merge (dc82866)Diff
    browser21.3 kB21.5 kB+139 B (+0.7%)
    main23.6 kB23.7 kB+139 B (+0.6%)
    module21.3 kB21.5 kB+139 B (+0.7%)

  • firebase

    TypeBase (8209266)Merge (dc82866)Diff
    firebase-ai.js51.3 kB51.4 kB+114 B (+0.2%)
    firebase-data-connect.js22.5 kB22.6 kB+68 B (+0.3%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/PtkDe8msGb.html

stephenarosaj
stephenarosaj approved these changes Oct 27, 2025
View reviewed changes
Copy link
Contributor

@stephenarosaj stephenarosaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Oct 27, 2025 •
edited
Loading

Size Analysis Report 1

Affected Products

  • @firebase/ai

    • LiveGenerativeModel

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size13.8 kB13.9 kB+120 B (+0.9%)
      size-with-ext-deps31.5 kB31.6 kB+120 B (+0.4%)

    • getLiveGenerativeModel

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size16.2 kB16.3 kB+120 B (+0.7%)
      size-with-ext-deps33.9 kB34.1 kB+120 B (+0.4%)

  • @firebase/data-connect

    • CallerSdkTypeEnum

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • Code

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.3 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • DataConnect

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.3 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • DataConnectError

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • DataConnectOperationError

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • MUTATION_STR

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.5 kB+64 B (+0.2%)

    • MutationManager

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • QUERY_STR

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.3 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • SOURCE_CACHE

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.3 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • SOURCE_SERVER

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • areTransportOptionsEqual

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • connectDataConnectEmulator

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.5 kB12.6 kB+64 B (+0.5%)
      size-with-ext-deps35.0 kB35.0 kB+64 B (+0.2%)

    • executeMutation

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.5 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.5 kB+64 B (+0.2%)

    • executeQuery

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.5 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.5 kB+64 B (+0.2%)

    • getDataConnect

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size13.0 kB13.1 kB+64 B (+0.5%)
      size-with-ext-deps38.0 kB38.0 kB+64 B (+0.2%)

    • mutationRef

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.5 kB12.5 kB+64 B (+0.5%)
      size-with-ext-deps30.5 kB30.6 kB+64 B (+0.2%)

    • parseOptions

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.3 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.4 kB+64 B (+0.2%)

    • queryRef

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.5 kB12.5 kB+64 B (+0.5%)
      size-with-ext-deps30.5 kB30.6 kB+64 B (+0.2%)

    • setLogLevel

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.5 kB+64 B (+0.2%)

    • subscribe

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size13.6 kB13.7 kB+68 B (+0.5%)
      size-with-ext-deps38.5 kB38.6 kB+68 B (+0.2%)

    • terminate

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.4 kB12.4 kB+64 B (+0.5%)
      size-with-ext-deps30.4 kB30.5 kB+64 B (+0.2%)

    • toQueryRef

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size13.2 kB13.3 kB+64 B (+0.5%)
      size-with-ext-deps38.2 kB38.2 kB+64 B (+0.2%)

    • validateArgs

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size13.2 kB13.3 kB+64 B (+0.5%)
      size-with-ext-deps38.1 kB38.2 kB+64 B (+0.2%)

    • validateDCOptions

      Size

      TypeBase (8209266)Merge (f15e702)Diff
      size12.6 kB12.6 kB+64 B (+0.5%)
      size-with-ext-deps30.6 kB30.7 kB+64 B (+0.2%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/TtWqovnXL4.html

@looptheloop88 looptheloop88 mentioned this pull request Oct 29, 2025
Closed
maneesht
maneesht commented Oct 29, 2025
View reviewed changes
common/api-review/data-connect.api.md
}

// @public
export interface DataConnectSubscription<Data, Variables> {
Copy link
Contributor Author

@maneesht maneesht Oct 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: this was removed as it's an internal interface wasn't being referenced by any of our public api functions

@maneesht maneesht merged commit c47bd71 into main Oct 30, 2025
37 of 38 checks passed
@maneesht maneesht deleted the mtewani/fix-oncomplete branch October 30, 2025 19:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hsubox76 hsubox76 hsubox76 approved these changes

@stephenarosaj stephenarosaj stephenarosaj approved these changes

@aashishpatil-g aashishpatil-g aashishpatil-g approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

subscribe's onComplete not working

5 participants

@maneesht @google-oss-bot @hsubox76 @stephenarosaj @aashishpatil-g