-
Notifications
You must be signed in to change notification settings - Fork 983
Unify Pipelines and Firestore classic in CDN and g3 builds #9323
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: console
Are you sure you want to change the base?
Unify Pipelines and Firestore classic in CDN and g3 builds #9323
Conversation
* Change (BETA) annotation to (Public Preview) * format * Minor bump
* Create Node CJS and ESM bundles * Add changeset * Run formatter * register version with node
* Fix vectorvalue docs * Use @link vector * Fix vector link with code tag
* Re-enable redirect tests * Fix lint
* WIP * Introduce VertexAIModel base class, add documentation, and respond to other comments * Generate devsite docs * revert dataconnect change * formatting * WIP * Introduce VertexAIModel base class, add documentation, and respond to other comments * Generate devsite docs * revert dataconnect change * formatting * Fix ImagenRequestConfig comment * Improve tests * Formatting * Add ImagenGenerationResponse * Formatting * Update to match API changes * fixes * format * Update API reports * add changeset * update * format * Update API reports * remove public docs * Nest imageFormat in outputOptions * remove unecessary console.log * Log warning if compressionQuality outside of range * format * Imagen Documentation (#8776) * Revert "remove public docs" This reverts commit f095563. * update docs * update docs * format * minor fixes * format * mark all APIs beta instead of public * review fixes * format * Replace (BETA) with (Public Preview) in docs * fix links * another pass * format * review fixes * Cleanup * update changeset --------- Co-authored-by: dlarocque <[email protected]>
* Add support for token-based usage metrics. Token measurement is broken down by modaliy, with separate counters for image, audio, etc. Tests are in version 6.*, so this change also includes bumping update_responses.sh * Use right name for unspecified enum * Update API reports * Make promptTokensDetails an array * Update API reports * Add missing documentation * Add changeset entry * Fix formatting errors * Update API reports * Add missing refdoc * Update API reports * Use correct formatting for Modality documentation. * Update API reports * Update docs * Update packages/vertexai/src/types/enums.ts Co-authored-by: rachelsaunders <[email protected]> * Update md files * Revert changes to api-extractor.json --------- Co-authored-by: rachelsaunders <[email protected]>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Bumps [cross-spawn](https://github.com/moxystudio/node-cross-spawn) from 7.0.3 to 7.0.6. - [Changelog](https://github.com/moxystudio/node-cross-spawn/blob/master/CHANGELOG.md) - [Commits](moxystudio/node-cross-spawn@v7.0.3...v7.0.6) --- updated-dependencies: - dependency-name: cross-spawn dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Adds a `postinstall` step to `@firebase/util` which hardcodes autoinit defaults into `@firebase/util/dist/postinstall.(m)js` for both CJS and ESM variants [go/firestack-autoinit](http://goto.google.com/firestack-autoinit). Hardcoding is important since environment variable substitution doesn't dive into a developer's `node_modules` folder. This gives us a framework agnostic way to inject configuration and is a more robust solution than the _experimental_ autoinit methods provided by Web Frameworks [go/firebase-api-client-autoinit](https://goto.google.com/firebase-api-client-autoinit). Once this lands, we'll backport to Hosting and Functions and aim to deprecate the other autoinit methods.
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Release 11.4.0
… of v1beta (#8820) * update API requests to point to v1 instead of v1beta * update changelog
* fix golden files test * update responses version --------- Co-authored-by: David Motsonashvili <[email protected]>
… cdn.ts to packages/firebase/firestore/pipelines
…wser unit testing.
| }) | ||
| }), | ||
|
|
||
| declareModuleReplacePlugin() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not obvious why this plugin is necessary. Can you add comments explaining the problem this solves?
| // The regex we created earlier | ||
| const moduleToReplace = | ||
| /declare module '\.\/\S+' \{\s+interface Firestore \{\s+pipeline\(\): PipelineSource<Pipeline>;\s+}\s*}/gm; | ||
|
|
||
| // What to replace it with (an empty string to remove it) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These comments seem out of date. Can you update them?
| ]; | ||
|
|
||
| // TODO - update the implementation to match all content in the declare module block. | ||
| function declareModuleReplacePlugin() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All our custom rollup plugins exist in scripts/build. Can you move this plugin to a new file in that directory?
| public asyncQueue: AsyncQueue, | ||
| private databaseInfo: DatabaseInfo, | ||
| /** | ||
| * @internal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think @internal is necessary here, since FirestoreClient is not a public API.
* dist/firestore/src/global_index.d.ts now includes pipelines in namespace 'pipelines' * Update global.ts * Custom replacer plugin to remove declare module block from global.d.ts * Update CDN and g3 builds of Firestore to include Pipelines in the firebase-firestore.js file * Updated CDN bundles so that firebase-firestore.js is not modified, but firebase-firestore-pipelines.js contains both classic and pipelines APIs. * Fix regression in _internalPipelineToExecutePipelineRequestProto * Fixing missing paths in package.json * Fix binary size script * Add support for index.cdn.ts files in packages/firebase. Then added a cdn.ts to packages/firebase/firestore/pipelines * Rename grpc_connection.node.test.ts, so the file is filtered from browser unit testing.
* clean up exports and imports * Fix implementation of Query to Pipeline for isNan, isNotNan, isNull, and isNotNull changes in the backend * fix tests to accomodate for backend changes to multiple sort stages * another test that the console usage will perform runtime validation of user data * formatting * Copy the latest pipelines tests into lite api pipelines tests. Fix a few minor bugs in the lite pipeline implementation * Remove special handling of null and nan in query to pipeline * remove function expresssions isNan, isNull, isNotNan, isNotNull, and error * Renamed len function to length, with a fix to the prune-dts script * lastest API review md files * fixed title is not null test
For CDN and G3 builds, we will output two bundles:
pipelines).