build: new internal builds for google3 #9139
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected ProductsNo changes between base commit (8072572) and merge commit (d9f3786).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (8072572) and merge commit (d9f3786).Test Logs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create new builds that are only triggered during the internal google3 build, for google3 consumers:
It also doesn't look like we need to do the convoluted rollup config swap that we do in the google3 import script (internal link: https://source.corp.google.com/piper///depot/google3/third_party/javascript/firebase/updateThirdParty.sh;rcl=666835113;l=91) when we have a special build:internal script that can simply call the other config, so I changed that.
I assume we need to roll up new typings for each of the new bundles, so I added a step to generate those.
An unfortunate complication is that simply exporting
*from each package leads to name collisions so every module needs to be namespaced with the product name, so thatinitializeAppmust be referred to asapp.initializeAppfor example. This is really going backwards toward the old compat packages but the g3 ecosystem doesn't really give us much choice.Also I noticed the rollup-internal.config.js builds every file that the main one does, including the non-cdn ones (such as the individual product entry points under firebase/) which doesn't seem necessary as they're not included in any BUILD target in google3, so I removed those. Will see if this causes a problem.
I will leave this as a branch and a draft that can be imported into google3 and iterated on based on whether it works there.