fix!(ai): convert TS enums exports in Firebase AI into const variables #9137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 8f555d1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (81,741 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
changed the title
hsubox76
changed the title
dlarocque
approved these changes
Jul 8, 2025
| @@ -118,6 +126,6 @@ export interface SchemaInterface extends SchemaShared<SchemaInterface> { | |||
| * @public | |||
| */ | |||
| export interface ObjectSchemaInterface extends SchemaInterface { | |||
| type: SchemaType.OBJECT; | |||
| type: 'object'; | |||
There was a problem hiding this comment.
Can we no longer use SchemaType.OBJECT here?
There was a problem hiding this comment.
No, error is: "'SchemaType' only refers to a type, but is being used as a namespace here." It's not an enum anymore so the only actual type that exists now is the string union. The const is JS code and not referenceable by a TS type-only interface.
egilmorez
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the AIP guidance here (internal link - excerpt below):
https://g3doc.corp.google.com/firebase/g3doc/aip/3270.md?cl=head#typescript-enums-and-const-enums
This could break some users depending on how they are consuming these enums so we will mark this as a breaking change and release with the breaking release.