build!: update build targets to ES2020 #9101
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (284,509 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
DellaBitta
reviewed
Jun 20, 2025
| "devDependencies": { | ||
| "@firebase/app": "0.13.1", | ||
| "@firebase/logger": "0.4.4", | ||
| "dependencies": { |
There was a problem hiding this comment.
Why did all of these dev dependencies suddenly become dependencies?
There was a problem hiding this comment.
We discussed offline. It's due to linter errors.
There was a problem hiding this comment.
They shouldn't be devDependencies because they're used in the builds of the test apps in this directory. The linter complains about it, if it's run. It doesn't affect the functionality of this package though and it's an internal package that isn't shipped to users.
DellaBitta
approved these changes
Jun 21, 2025
hsubox76
changed the title
hsubox76
changed the title
hsubox76
requested review from
erikeldridge,
a team,
visumickey,
lisajian,
Xiaoshouzi-gh,
sam-gc,
pashanka,
mansisampat,
NhienLam,
zwu52,
maneesht and
tonyjhuang
as code owners
dlarocque
requested changes
Jul 8, 2025
Drive-by comment: should we just omit the year, and just call the file |
Done per @dconeybe 's suggestion of removing the year, plus updating a bunch of other places I missed, and comments. The year is still in the platform logging tag though. That's probably helpful information. |
dlarocque
approved these changes
Jul 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating build targets to "ES2020" which should be widely adopted by now. On our supported environments page we recommend ES Stable polyfills, and "ES stable" is 2024 at this point. This will go out with the v12 breaking change.
The only snag is that ES2020 does not play well with "istanbul-instrumenter-loader" which is the coverage plugin that runs on karma tests. It hasn't been updated in years so we need to find a new coverage tool. We don't really report the coverage results anywhere right now anyway (I think our reporting is broken), so we're not losing anything, although we do need to fix all of this. We are still running command-line istanbul (not through the loader) on all node tests though.
The only other fix was moving some deps around in the
size-analysisfolder to satisfy the linter.