Skip to content

An attempt at fixing #12168 by only returning the cached data at the child path rather than at the parent #12169

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

An attempt at fixing #12168 by only returning the cached data at the child path rather than at the parent #12169

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions FirebaseDatabase/Sources/Core/FSyncTree.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -737,11 +737,12 @@ - (FIndexedNode *)persistenceServerCache:(FQuerySpec *)querySpec {
- (id<FNode>)getServerValue:(FQuerySpec *)query {
__block id<FNode> serverCacheNode = nil;
__block FSyncPoint *targetSyncPoint = nil;
__block FPath *relativePath = nil;
[self.syncPointTree
forEachOnPath:query.path
whileBlock:^BOOL(FPath *pathToSyncPoint, FSyncPoint *syncPoint) {
FPath *relativePath = [FPath relativePathFrom:pathToSyncPoint
to:query.path];
relativePath = [FPath relativePathFrom:pathToSyncPoint
to:query.path];
serverCacheNode =
[syncPoint completeEventCacheAtPath:relativePath];
targetSyncPoint = syncPoint;
Expand Down Expand Up @@ -772,7 +773,7 @@ - (FIndexedNode *)persistenceServerCache:(FQuerySpec *)querySpec {
getView:query
writesCache:[_pendingWriteTree childWritesForPath:[query path]]
serverCache:serverCache];
return [view completeEventCache];
return [view completeEventCacheFor: relativePath];
}

/**
Expand Down