#1703: fixing logger runtime exceptions

[bitekas]

Description

Fixing the issue #1703.

Googleapis returns a proxy to an object with a missing "size" property due to an outdated node-fetch library, and this causes the logger to throw an exception. This PR fixes that.

Also improved lookup time to O(1), and fixed a potential bug for logging objects such as { toJSON: true }: in the current implementation debug({toJSON: true}); is throwing an exception. Pretty nasty given the amount of the Internet using this logger, and hard to triage. This is also fixed.

Code sample

[CorieW]

These changes seem to work well.

Before I see about getting this reviewed and merged in, would be able to fix the linting problem?

• https://github.com/firebase/firebase-functions/actions/runs/15518016835/job/43776991906?pr=1704#step:5:1534

Thanks for your contribution @bitekas.

[bitekas]

@CorieW the linter errors are fixed.

FYI, here's the pull request to resolve the underlying android publisher problem: node-fetch/node-fetch#1849, they are linked.

[Copilot]

Pull Request Overview

This PR fixes logger runtime exceptions by addressing issues with circular reference handling and improving lookup efficiency.

• Refactored circular reference detection to utilize a Set instead of an array for O(1) lookup.
• Updated property iteration logic to better handle errors and inherited properties.

Comments suppressed due to low confidence (2)

src/logger/index.ts:76

• The try-catch block here may obscure underlying serialization errors that could be useful for debugging. Consider logging the error or handling it in a way that preserves useful error context.

try { if (refs.has(obj[k])) { returnObj[k] = "[Circular]"; } else { returnObj[k] = removeCircular(obj[k], refs); } } catch { returnObj[k] = "[Error - cannot serialize]"; }

src/logger/index.ts:85

• [nitpick] The fallback for inherited properties may introduce unexpected serialization output. Consider reviewing whether prototype properties should be serialized or omitted entirely.

else { returnObj[k] = "[Error - defined in the prototype but missing in the object]"; }

[cabljac]

lgtm!

[taeold]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces fixes and improvements to the logging serialization logic. The change to use a Set for circular reference detection is a performance enhancement. The fixes for objects with a non-function toJSON property and for properties that throw on access make the logger more robust. The handling of prototype properties could lead to incorrect serialization for objects using inheritance, and a change has been suggested to align with standard serializer behavior by ignoring these properties.