Skip to content

Fix incorrect model name in count token requests to the developer API backend #7011

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025

Conversation

davidmotson
Copy link
Collaborator

No description provided.

Copy link
Contributor

github-actions bot commented Jun 3, 2025

📝 PRs merging into main branch

Our main branch should always be in a releasable state. If you are working on a larger change, or if you don't want this change to see the light of the day just yet, consider using a feature branch first, and only merge into the main branch when the code complete and ready to be released.

@davidmotson
Copy link
Collaborator Author

This should fix #7008

@google-oss-bot
Copy link
Contributor

Copy link
Contributor

github-actions bot commented Jun 3, 2025

Test Results

 24 files  + 24   24 suites  +24   33s ⏱️ +33s
102 tests +102  102 ✅ +102  0 💤 ±0  0 ❌ ±0 
204 runs  +204  204 ✅ +204  0 💤 ±0  0 ❌ ±0 

Results for commit f5e59e1. ± Comparison against base commit f03fe1c.

@google-oss-bot
Copy link
Contributor

Size Report 1

Affected Products

  • firebase-ai

    TypeBase (f03fe1c)Merge (9b0d2b5)Diff
    aar825 kB825 kB+170 B (+0.0%)
    apk (aggressive)1.55 MB1.55 MB+104 B (+0.0%)
    apk (release)9.52 MB9.52 MB+188 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/7RPCGCnuhT.html

@davidmotson davidmotson merged commit d4a3068 into main Jun 4, 2025
31 of 32 checks passed
@davidmotson davidmotson deleted the davidmotson.google_count_token_modelname branch June 4, 2025 19:46
@kaibolay kaibolay changed the title Davidmotson.google count token modelname Fix incorrect model name in count token requests to the developer API backend Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants