Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datacube: fixing caching for csv #3891

Merged
merged 2 commits into from
Feb 12, 2025
Merged

Datacube: fixing caching for csv #3891

merged 2 commits into from
Feb 12, 2025

Conversation

gs-gunjan
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gs-gunjan gs-gunjan requested a review from a team as a code owner February 12, 2025 09:53
Copy link

changeset-bot bot commented Feb 12, 2025

🦋 Changeset detected

Latest commit: 9e98725

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-shared Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-code-editor Patch
@finos/legend-data-cube Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-graph Patch
@finos/legend-lego Patch
@finos/legend-query-builder Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-server-showcase Patch
@finos/legend-storage Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes missing coverage. Please review.

Project coverage is 46.34%. Comparing base (c0a5458) to head (9e98725).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 9 Missing ⚠️
...ackages/legend-shared/src/format/FormatterUtils.ts 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3891      +/-   ##
==========================================
- Coverage   46.48%   46.34%   -0.15%     
==========================================
  Files        2255     2255              
  Lines      394502   394495       -7     
  Branches    17151    17195      +44     
==========================================
- Hits       183379   182822     -557     
- Misses     210172   210691     +519     
- Partials      951      982      +31     
Files with missing lines Coverage Δ
...ackages/legend-shared/src/format/FormatterUtils.ts 90.29% <60.00%> (-0.77%) ⬇️
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% <0.00%> (ø)

... and 111 files with indirect coverage changes

@gs-gunjan gs-gunjan reopened this Feb 12, 2025
@akphi akphi merged commit 8a89338 into finos:master Feb 12, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants