Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataCube: Upload data via file into DataCube grid #3886

Merged
merged 4 commits into from
Feb 14, 2025
Merged

Conversation

gs-gunjan
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

Copy link

changeset-bot bot commented Feb 11, 2025

🦋 Changeset detected

Latest commit: 4a6b96a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 39 packages
Name Type
@finos/legend-application-data-cube Minor
@finos/legend-data-cube Patch
@finos/legend-shared Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application Patch
@finos/legend-art Patch
@finos/legend-code-editor Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-tracer-zipkin Patch
@finos/legend-graph Patch
@finos/legend-lego Patch
@finos/legend-server-depot Patch
@finos/legend-server-sdlc Patch
@finos/legend-server-showcase-deployment Patch
@finos/legend-server-showcase Patch
@finos/legend-storage Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 1.84255% with 586 lines in your changes missing coverage. Please review.

Project coverage is 46.28%. Comparing base (82ea08b) to head (4a6b96a).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 213 Missing ⚠️
...ts/builder/source/CSVFileDataCubeSourceBuilder.tsx 0.00% 128 Missing ⚠️
...uilder/source/CSVFileDataCubeSourceBuilderState.ts 0.00% 88 Missing and 1 partial ⚠️
...data-cube/src/stores/LegendDataCubeDuckDBEngine.ts 0.00% 73 Missing ⚠️
...ata-cube/src/stores/model/CSVFileDataCubeSource.ts 0.00% 60 Missing and 1 partial ⚠️
...e/src/components/builder/LegendDataCubeCreator.tsx 0.00% 6 Missing ⚠️
.../src/stores/builder/LegendDataCubeCreatorState.tsx 0.00% 6 Missing ⚠️
...e/src/components/builder/LegendDataCubeBuilder.tsx 0.00% 5 Missing ⚠️
...egend-data-cube/src/stores/core/DataCubeEngine.tsx 60.00% 2 Missing ⚠️
...ackages/legend-shared/src/format/FormatterUtils.ts 80.00% 2 Missing ⚠️
... and 1 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3886      +/-   ##
==========================================
- Coverage   46.41%   46.28%   -0.14%     
==========================================
  Files        2255     2258       +3     
  Lines      394495   395067     +572     
  Branches    11894    16395    +4501     
==========================================
- Hits       183086   182837     -249     
- Misses     210743   211470     +727     
- Partials      666      760      +94     
Files with missing lines Coverage Δ
...cube/src/stores/core/model/CachedDataCubeSource.ts 74.07% <ø> (-1.79%) ⬇️
...builder/source/LegendDataCubeSourceBuilderState.ts 0.00% <0.00%> (ø)
...egend-data-cube/src/stores/core/DataCubeEngine.tsx 89.69% <60.00%> (-0.46%) ⬇️
...ackages/legend-shared/src/format/FormatterUtils.ts 89.83% <80.00%> (-0.46%) ⬇️
...e/src/components/builder/LegendDataCubeBuilder.tsx 0.00% <0.00%> (ø)
...e/src/components/builder/LegendDataCubeCreator.tsx 0.00% <0.00%> (ø)
.../src/stores/builder/LegendDataCubeCreatorState.tsx 0.00% <0.00%> (ø)
...ata-cube/src/stores/model/CSVFileDataCubeSource.ts 0.00% <0.00%> (ø)
...data-cube/src/stores/LegendDataCubeDuckDBEngine.ts 0.00% <0.00%> (ø)
...uilder/source/CSVFileDataCubeSourceBuilderState.ts 0.00% <0.00%> (ø)
... and 2 more

... and 390 files with indirect coverage changes

@gs-gunjan gs-gunjan force-pushed the csv branch 2 times, most recently from 3f4bb19 to 67bb2a3 Compare February 13, 2025 09:37
@gs-gunjan gs-gunjan marked this pull request as ready for review February 13, 2025 12:31
@gs-gunjan gs-gunjan requested a review from a team as a code owner February 13, 2025 12:31
@gs-gunjan gs-gunjan marked this pull request as draft February 13, 2025 12:50
@gs-gunjan gs-gunjan marked this pull request as ready for review February 13, 2025 12:57
@gs-gunjan
Copy link
Contributor Author

Screenshot 2025-02-14 at 4 03 14 PM Screenshot 2025-02-14 at 4 04 08 PM Screenshot 2025-02-14 at 4 04 24 PM

@akphi akphi merged commit 582fda1 into finos:master Feb 14, 2025
16 checks passed
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 16, 2025
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 16, 2025
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 16, 2025
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 16, 2025
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 16, 2025
akphi added a commit that referenced this pull request Feb 17, 2025
* datacube: minor cleanups

* datacube: minor cleanup to cached source model

* datacube: improve debugging around execution

* studio: support import execute input

* datacube: cleanup post #3886
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants