Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: rename DataCubeQuery to DataCubeSpecification and UX enhancements #3882

Merged
merged 10 commits into from
Feb 11, 2025

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Feb 10, 2025

No description provided.

Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: 2a1dcd8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-studio Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-query-builder Patch
@finos/legend-data-cube Patch
@finos/legend-graph Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-pure-ide Patch
@finos/legend-code-editor Patch
@finos/legend-lego Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 10, 2025

Codecov Report

Attention: Patch coverage is 17.32865% with 2352 lines in your changes missing coverage. Please review.

Project coverage is 46.37%. Comparing base (ddcd23b) to head (2a1dcd8).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
.../src/stores/builder/LegendDataCubeBuilderStore.tsx 0.00% 515 Missing and 1 partial ⚠️
...e/src/components/builder/LegendDataCubeBuilder.tsx 0.00% 330 Missing and 1 partial ⚠️
...e/src/stores/builder/LegendDataCubeLoaderState.tsx 0.00% 247 Missing and 1 partial ⚠️
...ube/src/components/builder/LegendDataCubeSaver.tsx 0.00% 183 Missing and 1 partial ⚠️
...end-data-cube/src/stores/view/DataCubeViewState.ts 8.39% 131 Missing ⚠️
...be/src/components/builder/LegendDataCubeLoader.tsx 0.00% 122 Missing ⚠️
...be/src/components/LegendDataCubeBlockingWindow.tsx 0.00% 119 Missing and 1 partial ⚠️
.../components/builder/LegendDataCubeSourceViewer.tsx 0.00% 107 Missing and 1 partial ⚠️
...nents/builder/LegendDataCubeDeleteConfirmation.tsx 0.00% 86 Missing and 1 partial ⚠️
...n-repl/src/components/LegendREPLWebApplication.tsx 0.00% 80 Missing ⚠️
... and 63 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3882      +/-   ##
==========================================
+ Coverage   45.63%   46.37%   +0.73%     
==========================================
  Files        2252     2255       +3     
  Lines      393447   394526    +1079     
  Branches    17045    17211     +166     
==========================================
+ Hits       179546   182950    +3404     
+ Misses     213116   210911    -2205     
+ Partials      785      665     -120     
Files with missing lines Coverage Δ
...der/source/AdhocQueryDataCubeSourceBuilderState.ts 0.00% <ø> (ø)
...er/source/LegendQueryDataCubeSourceBuilderState.ts 0.00% <ø> (ø)
...ication-query/src/__lib__/LegendQueryNavigation.ts 59.77% <100.00%> (ø)
...es/legend-data-cube/src/__lib__/DataCubeSetting.ts 100.00% <100.00%> (+100.00%) ⬆️
...be/src/stores/core/DataCubeConfigurationBuilder.ts 100.00% <100.00%> (ø)
...-data-cube/src/stores/core/DataCubeQueryBuilder.ts 92.35% <100.00%> (ø)
...-cube/src/stores/core/DataCubeQueryBuilderUtils.ts 86.20% <100.00%> (ø)
...ta-cube/src/stores/core/DataCubeSnapshotBuilder.ts 98.71% <100.00%> (ø)
...be/src/stores/core/DataCubeSnapshotBuilderUtils.ts 93.54% <100.00%> (ø)
...ore/aggregation/DataCubeQueryAggregateOperation.ts 100.00% <100.00%> (ø)
... and 118 more

... and 380 files with indirect coverage changes

@akphi akphi marked this pull request as ready for review February 11, 2025 03:09
@akphi akphi requested a review from a team as a code owner February 11, 2025 03:09
@akphi akphi merged commit f8cd2bf into finos:master Feb 11, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants