Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: fix aggregation count issue #3876

Merged
merged 1 commit into from
Feb 7, 2025
Merged

datacube: fix aggregation count issue #3876

merged 1 commit into from
Feb 7, 2025

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Feb 7, 2025

No description provided.

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 3e4e17d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-data-cube Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@akphi akphi marked this pull request as ready for review February 7, 2025 05:18
@akphi akphi requested a review from a team as a code owner February 7, 2025 05:18
Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0% with 16 lines in your changes missing coverage. Please review.

Project coverage is 45.62%. Comparing base (2936c20) to head (3e4e17d).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% 11 Missing ⚠️
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3876      +/-   ##
==========================================
+ Coverage   45.57%   45.62%   +0.04%     
==========================================
  Files        2252     2252              
  Lines      393452   393450       -2     
  Branches    11726    17029    +5303     
==========================================
+ Hits       179330   179516     +186     
+ Misses     213412   212905     -507     
- Partials      710     1029     +319     
Files with missing lines Coverage Δ
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% <0.00%> (ø)
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% <0.00%> (ø)

... and 170 files with indirect coverage changes

@akphi akphi merged commit c7384e1 into finos:master Feb 7, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants