Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: fix type conversion for caching #3873

Merged
merged 1 commit into from
Feb 7, 2025
Merged

datacube: fix type conversion for caching #3873

merged 1 commit into from
Feb 7, 2025

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Feb 7, 2025

No description provided.

Copy link

changeset-bot bot commented Feb 7, 2025

🦋 Changeset detected

Latest commit: 94a1787

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-data-cube Patch
@finos/legend-graph Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-code-editor Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 0.71429% with 139 lines in your changes missing coverage. Please review.

Project coverage is 45.61%. Comparing base (47ca81b) to head (94a1787).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 90 Missing ⚠️
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 41 Missing ⚠️
...ponents/query-builder/LegendDataCubeQuerySaver.tsx 0.00% 5 Missing ⚠️
...gend-data-cube/src/components/DataCubeTitleBar.tsx 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3873      +/-   ##
==========================================
- Coverage   45.70%   45.61%   -0.10%     
==========================================
  Files        2252     2252              
  Lines      393357   393452      +95     
  Branches    17137    11717    -5420     
==========================================
- Hits       179796   179476     -320     
- Misses     212554   213510     +956     
+ Partials     1007      466     -541     
Files with missing lines Coverage Δ
...ackages/legend-graph/src/STO_Relational_Exports.ts 96.90% <100.00%> (+0.03%) ⬆️
packages/legend-graph/src/index.ts 0.00% <ø> (ø)
...gend-data-cube/src/components/DataCubeTitleBar.tsx 0.00% <0.00%> (ø)
...ponents/query-builder/LegendDataCubeQuerySaver.tsx 0.00% <0.00%> (ø)
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% <0.00%> (ø)
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% <0.00%> (ø)

... and 414 files with indirect coverage changes

@akphi akphi marked this pull request as ready for review February 7, 2025 01:26
@akphi akphi requested a review from a team as a code owner February 7, 2025 01:26
@akphi akphi merged commit 95c26ec into finos:master Feb 7, 2025
16 checks passed
@akphi akphi deleted the dt57 branch February 7, 2025 01:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants