Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable caching of data for hosted data cube #3862

Merged
merged 3 commits into from
Feb 5, 2025
Merged

Enable caching of data for hosted data cube #3862

merged 3 commits into from
Feb 5, 2025

Conversation

gs-gunjan
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@gs-gunjan gs-gunjan requested a review from a team as a code owner February 5, 2025 10:45
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: d295f81

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@finos/legend-application-data-cube Minor
@finos/legend-application-repl Minor
@finos/legend-data-cube Minor
@finos/legend-dev-utils Minor
@finos/legend-graph Minor
@finos/legend-query-builder Minor
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-query Patch
@finos/legend-application-studio Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-code-editor Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov Codecov
Copy link

codecov bot commented Feb 5, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 7.28814% with 547 lines in your changes missing coverage. Please review.

Project coverage is 45.65%. Comparing base (25bf6db) to head (d295f81).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 233 Missing ⚠️
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 131 Missing and 1 partial ⚠️
...ata-cube/src/components/view/grid/DataCubeGrid.tsx 0.00% 41 Missing ⚠️
...cube/src/stores/core/model/CachedDataCubeSource.ts 0.00% 24 Missing and 1 partial ⚠️
packages/legend-graph/src/index.ts 0.00% 23 Missing ⚠️
...d-application-data-cube/src/stores/DuckDBWASM.d.ts 0.00% 21 Missing and 1 partial ⚠️
...ata-cube/src/stores/view/grid/DataCubeGridState.ts 0.00% 18 Missing ⚠️
...end-data-cube/src/stores/view/DataCubeViewState.ts 0.00% 16 Missing ⚠️
...elational/connection/V1_DatasourceSpecification.ts 28.57% 10 Missing ⚠️
...egend-data-cube/src/stores/core/DataCubeEngine.tsx 64.28% 5 Missing ⚠️
... and 8 more
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3862      +/-   ##
==========================================
- Coverage   45.84%   45.65%   -0.20%     
==========================================
  Files        2249     2252       +3     
  Lines      392589   393176     +587     
  Branches    11778    17040    +5262     
==========================================
- Hits       179990   179510     -480     
- Misses     211894   212640     +746     
- Partials      705     1026     +321
Files with missing lines Coverage Δ
...onal/connection/V1_RelationalDatabaseConnection.ts 100.00% <100.00%> (ø)
packages/legend-graph/src/graph/Core_HashUtils.ts 100.00% <100.00%> (ø)
...nents/query-builder/LegendDataCubeQueryBuilder.tsx 0.00% <0.00%> (ø)
packages/legend-data-cube/src/index.tsx 0.00% <0.00%> (ø)
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% <0.00%> (ø)
...relational/connection/V1_AuthenticationStrategy.ts 65.34% <77.77%> (+0.67%) ⬆️
...cation-repl/src/stores/LegendREPLDataCubeEngine.ts 0.00% <0.00%> (ø)
...src/stores/data-cube/QueryBuilderDataCubeEngine.ts 18.97% <0.00%> (-0.22%) ⬇️
...ges/legend-data-cube/src/stores/DataCubeOptions.ts 0.00% <0.00%> (ø)
...egend-data-cube/src/stores/core/DataCubeEngine.tsx 93.95% <64.28%> (-1.47%) ⬇️
... and 10 more

... and 235 files with indirect coverage changes

@gs-gunjan
Copy link
Contributor Author

gs-gunjan commented Feb 5, 2025 •
edited
Loading

Old PR: #3860

akphi
akphi previously approved these changes Feb 5, 2025
View reviewed changes
packages/legend-application-data-cube/src/stores/LegendDataCubeDataCubeEngine.ts
guaranteeType(
x,
V1_SQLExecutionNode,
`Can't generate sql for the query`,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`Can't generate sql for the query`,
`Can't generate SQL for the query`,

packages/legend-application-data-cube/src/stores/LegendDataCubeDataCubeEngine.ts
)
.at(-1)?.sqlQuery;
}
assertNonNullable(sql, `Can't generate sql for the query`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
assertNonNullable(sql, `Can't generate sql for the query`);
assertNonNullable(sql, `Can't generate SQL for the query`);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can merge this with line 427 using guaranteeNonNullable, doing something similar to line 458

@akphi akphi merged commit 2db9bbc into finos:master Feb 5, 2025
15 checks passed
@akphi akphi deleted the review-caching1 branch February 5, 2025 14:17
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 5, 2025
@akphi
datacube: cleanup post finos#3862
958a9e9
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 5, 2025
@akphi
datacube: cleanup post finos#3862
7c65114
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 5, 2025
@akphi
datacube: cleanup post finos#3862
7345511
MauricioUyaguari pushed a commit that referenced this pull request Feb 5, 2025
@akphi
datacube: simplify caching support (#3846)
8793609 
* testing: modify ag-grid tests

* cleanup post #3849

* datacube: cleanup exposed utilities

* datacube: simplify #3861

* datacube: cleanup post #3862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akphi akphi akphi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gs-gunjan @akphi