Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show name of Saved Query as Report Title #3861

Merged

Conversation

kelly-thai
Copy link
Contributor

Summary

How did you test this change?

  • Test(s) added
  • Manual testing (please provide screenshots/recordings)
  • No testing (please provide an explanation)

@kelly-thai kelly-thai requested a review from a team as a code owner February 4, 2025 19:04
Copy link

changeset-bot bot commented Feb 4, 2025

🦋 Changeset detected

Latest commit: c73040b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 28 packages
Name Type
@finos/legend-application-data-cube Patch
@finos/legend-data-cube Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query Patch
@finos/legend-application-repl Patch
@finos/legend-application-studio Patch
@finos/legend-query-builder Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 27.77778% with 13 lines in your changes missing coverage. Please review.

Project coverage is 45.70%. Comparing base (f61dfe4) to head (c73040b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 11 Missing ⚠️
packages/legend-data-cube/src/index.tsx 0.00% 1 Missing ⚠️
...end-data-cube/src/stores/view/DataCubeViewState.ts 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3861      +/-   ##
==========================================
- Coverage   45.79%   45.70%   -0.09%     
==========================================
  Files        2249     2249              
  Lines      392571   392589      +18     
  Branches    17150    17068      -82     
==========================================
- Hits       179783   179439     -344     
- Misses     211820   212126     +306     
- Partials      968     1024      +56     
Files with missing lines Coverage Δ
...egend-data-cube/src/stores/core/DataCubeEngine.tsx 95.42% <100.00%> (+0.08%) ⬆️
packages/legend-data-cube/src/index.tsx 0.00% <0.00%> (ø)
...end-data-cube/src/stores/view/DataCubeViewState.ts 0.00% <0.00%> (ø)
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% <0.00%> (ø)

... and 59 files with indirect coverage changes

@MauricioUyaguari MauricioUyaguari merged commit 25bf6db into finos:master Feb 4, 2025
16 checks passed
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 5, 2025
akphi added a commit to akphi/legend-studio that referenced this pull request Feb 5, 2025
MauricioUyaguari pushed a commit that referenced this pull request Feb 5, 2025
* testing: modify ag-grid tests

* cleanup post #3849

* datacube: cleanup exposed utilities

* datacube: simplify #3861

* datacube: cleanup post #3862
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants