Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

datacube: simplify caching support #3846

Merged
merged 5 commits into from
Feb 5, 2025
Merged

Conversation

akphi
Copy link
Contributor

@akphi akphi commented Jan 28, 2025

No description provided.

Copy link

changeset-bot bot commented Jan 28, 2025

🦋 Changeset detected

Latest commit: 7345511

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@finos/legend-query-builder Patch
@finos/legend-application-data-cube Patch
@finos/legend-application-query Patch
@finos/legend-application Patch
@finos/legend-data-cube Patch
@finos/legend-vscode-extension-dependencies Patch
@finos/legend-application-repl Patch
@finos/legend-graph Patch
@finos/legend-application-studio Patch
@finos/legend-extension-dsl-data-quality Patch
@finos/legend-extension-dsl-data-space-studio Patch
@finos/legend-extension-dsl-data-space Patch
@finos/legend-extension-dsl-service Patch
@finos/legend-application-data-cube-bootstrap Patch
@finos/legend-application-query-bootstrap Patch
@finos/legend-application-pure-ide-deployment Patch
@finos/legend-application-pure-ide Patch
@finos/legend-application-studio-bootstrap Patch
@finos/legend-extension-assortment Patch
@finos/legend-extension-dsl-diagram Patch
@finos/legend-extension-dsl-persistence Patch
@finos/legend-extension-dsl-text Patch
@finos/legend-extension-store-flat-data Patch
@finos/legend-extension-store-relational Patch
@finos/legend-extension-store-service-store Patch
@finos/legend-lego Patch
@finos/legend-application-repl-deployment Patch
@finos/legend-code-editor Patch
@finos/legend-application-data-cube-deployment Patch
@finos/legend-application-query-deployment Patch
@finos/legend-application-studio-deployment Patch
@finos/legend-server-showcase-deployment Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 16.13876% with 556 lines in your changes missing coverage. Please review.

Project coverage is 45.63%. Comparing base (2db9bbc) to head (7345511).
Report is 3 commits behind head on master.

Files with missing lines Patch % Lines
...ta-cube/src/stores/LegendDataCubeDataCubeEngine.ts 0.00% 115 Missing ⚠️
...data-cube/src/stores/LegendDataCubeCacheManager.ts 0.00% 82 Missing ⚠️
...end-data-cube/src/stores/view/DataCubeViewState.ts 0.00% 46 Missing ⚠️
...nents/query-builder/LegendDataCubeQueryBuilder.tsx 0.00% 26 Missing ⚠️
.../query-builder/LegendDataCubeQueryBuilderStore.tsx 0.00% 26 Missing ⚠️
...ata-cube/src/stores/view/grid/DataCubeGridState.ts 0.00% 24 Missing ⚠️
...lication/src/stores/navigation/BrowserNavigator.ts 0.00% 22 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridClientEngine.ts 0.00% 20 Missing ⚠️
...e/src/stores/view/grid/DataCubeGridQueryBuilder.ts 0.00% 19 Missing ⚠️
...ource-builder/LegendQueryDataCubeSourceBuilder.tsx 0.00% 17 Missing ⚠️
... and 24 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3846      +/-   ##
==========================================
- Coverage   45.65%   45.63%   -0.02%     
==========================================
  Files        2252     2252              
  Lines      393176   393262      +86     
  Branches    17080    16356     -724     
==========================================
- Hits       179485   179480       -5     
- Misses     212983   212995      +12     
- Partials      708      787      +79     
Files with missing lines Coverage Δ
...be/src/stores/core/DataCubeConfigurationBuilder.ts 100.00% <100.00%> (ø)
...be/src/stores/core/DataCubeQuerySnapshotBuilder.ts 98.71% <100.00%> (-0.01%) ⬇️
...ational/connection/RelationalDatabaseConnection.ts 100.00% <100.00%> (ø)
.../legend-vscode-extension-dependencies/src/index.ts 0.00% <ø> (ø)
...-data-cube/src/__lib__/LegendDataCubeNavigation.ts 0.00% <0.00%> (ø)
...be/src/components/LegendDataCubeWebApplication.tsx 0.00% <0.00%> (ø)
...ce-builder/AdhocQueryDataCubeSourceBuilderState.ts 0.00% <0.00%> (ø)
...ges/legend-data-cube/src/stores/DataCubeOptions.ts 0.00% <0.00%> (ø)
...c/stores/core/DataCubeQuerySnapshotBuilderUtils.ts 93.45% <50.00%> (-0.01%) ⬇️
...rc/stores/services/DataCubeQuerySnapshotService.ts 0.00% <0.00%> (ø)
... and 28 more

... and 397 files with indirect coverage changes

@akphi akphi marked this pull request as ready for review January 29, 2025 17:53
@akphi akphi requested a review from a team as a code owner January 29, 2025 17:53
@akphi akphi marked this pull request as draft January 29, 2025 17:53
@akphi akphi force-pushed the dt54 branch 4 times, most recently from 340adc8 to 38c8a29 Compare February 5, 2025 05:09
@akphi akphi force-pushed the dt54 branch 2 times, most recently from 958a9e9 to 7c65114 Compare February 5, 2025 19:47
@akphi akphi changed the title datacube: dimensions datacube: simplify caching support Feb 5, 2025
@akphi akphi marked this pull request as ready for review February 5, 2025 20:10
@MauricioUyaguari MauricioUyaguari merged commit 8793609 into finos:master Feb 5, 2025
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants