relation: fix cast for decimal columns (#3400)

* relation: fix cast for decimal columns * fix test
finos · Feb 8, 2025 · b740a5d · b740a5d
1 parent e497d27
commit b740a5d
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 2 deletions.
diff --git a/...n/execution/stores/relational/test/semiStructured/TestSnowflakeExplodeSemiStructured.java b/...n/execution/stores/relational/test/semiStructured/TestSnowflakeExplodeSemiStructured.java
@@ -321,12 +321,12 @@ public void testSemiStructuredQueryWithMultipleFieldTypes()
         String snowflakeExpected =
                 "    Relational\n" +
                         "    (\n" +
-                        "      type = TDS[(Manufacturer Id, Integer, INT, \"\"), (Is Tax Exempt, Boolean, BIT, \"\"), (Date Foudned, StrictDate, DATE, \"\"), (Name, String, VARCHAR(8192), \"\"), (Annual Tax Rate, Float, FLOAT, \"\"), (Hourly Rate, Decimal, \"\", \"\")]\n" +
+                        "      type = TDS[(Manufacturer Id, Integer, INT, \"\"), (Is Tax Exempt, Boolean, BIT, \"\"), (Date Foudned, StrictDate, DATE, \"\"), (Name, String, VARCHAR(8192), \"\"), (Annual Tax Rate, Float, FLOAT, \"\"), (Hourly Rate, Decimal, FLOAT, \"\")]\n" +
                         "      resultColumns = [(\"Manufacturer Id\", INT), (\"Is Tax Exempt\", \"\"), (\"Date Foudned\", \"\"), (\"Name\", \"\"), (\"Annual Tax Rate\", \"\"), (\"Hourly Rate\", \"\")]\n" +
                         "      sql = select \"root\".MANUFACTURER_ID as \"Manufacturer Id\", \"root\".MANUFACTURER_DETAILS['isTaxExempt']::boolean as \"Is Tax Exempt\", \"root\".MANUFACTURER_DETAILS['dateFounded']::date as \"Date Foudned\", \"root\".MANUFACTURER_DETAILS['name']::varchar as \"Name\", \"root\".MANUFACTURER_DETAILS['annualTaxRate']::float as \"Annual Tax Rate\", \"root\".MANUFACTURER_DETAILS['hourlyRate'] as \"Hourly Rate\" from Semistructured.Manufacturers as \"root\" where \"root\".MANUFACTURER_DETAILS['isTaxExempt']::boolean\n" +
                         "      connection = RelationalDatabaseConnection(type = \"Snowflake\")\n" +
                         "    )\n";
-        String TDSType = "  type = TDS[(Manufacturer Id, Integer, INT, \"\"), (Is Tax Exempt, Boolean, BIT, \"\"), (Date Foudned, StrictDate, DATE, \"\"), (Name, String, VARCHAR(8192), \"\"), (Annual Tax Rate, Float, FLOAT, \"\"), (Hourly Rate, Decimal, \"\", \"\")]\n";
+        String TDSType = "  type = TDS[(Manufacturer Id, Integer, INT, \"\"), (Is Tax Exempt, Boolean, BIT, \"\"), (Date Foudned, StrictDate, DATE, \"\"), (Name, String, VARCHAR(8192), \"\"), (Annual Tax Rate, Float, FLOAT, \"\"), (Hourly Rate, Decimal, FLOAT, \"\")]\n";
         Assert.assertEquals(wrapPreAndFinallyExecutionSqlQuery(TDSType, snowflakeExpected), snowflakePlan);
     }
 

diff --git a/...re/src/main/resources/core_relational/relational/transform/fromPure/pureToRelational.pure b/...re/src/main/resources/core_relational/relational/transform/fromPure/pureToRelational.pure
@@ -30,6 +30,7 @@ function meta::relational::transform::fromPure::pureTypeToDataTypeMap():Map<Type
 {
    newMap([
       pair(Integer, ^meta::relational::metamodel::datatype::Integer()),
+      pair(Decimal, ^meta::relational::metamodel::datatype::Float()),
       pair(Float, ^meta::relational::metamodel::datatype::Float()),
       pair(Number, ^meta::relational::metamodel::datatype::Float()),
       pair(String, ^meta::relational::metamodel::datatype::Varchar(size = 200)),