Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SafetyElement: Add property emphasizedBody #1381

Merged
merged 4 commits into from
Sep 23, 2024

Conversation

bstien
Copy link
Member

@bstien bstien commented Sep 23, 2024

Why?

There are some new requirements for safety elements, and we need to present some optional text in bold.

What?

  • Add property emphasizedBody that will be shown below body.
  • Update snapshot tests.
  • Minor cleanup/reorganization of SafetyElementsView.ElementContentView.

Version Change

Minor.

UI Changes

Screenshot 2024-09-23 at 09 28 34

@bstien bstien requested review from a team, pbodsk and dinsen and removed request for a team September 23, 2024 08:38
Copy link
Collaborator

@pbodsk pbodsk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👏

Bonus points for wrapping those long lines 🥇

:shipit:

@bstien bstien merged commit 5d3c8d6 into master Sep 23, 2024
1 check passed
@bstien bstien deleted the safety-element/add-emphasized-body branch September 23, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants