Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: set initial isLoading according to config.immediate #144

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

JuroUhlar
Copy link
Contributor

Should fix #141

@JuroUhlar JuroUhlar requested a review from ilfa as a code owner March 14, 2024 18:51
Copy link

github-actions bot commented Mar 14, 2024

Coverage report

St.
Category Percentage Covered / Total
🟢 Statements 91.87% 192/209
🟢 Branches
82.14% (+0.66% 🔼)
46/56
🟡 Functions 71.7% 38/53
🟢 Lines 91.94% 171/186

Test suite run success

19 tests passing in 5 suites.

Report generated by 🧪jest coverage report action from 3194f33

Show full coverage report
St File % Stmts % Branch % Funcs % Lines Uncovered Line #s
🟢 All files 91.86 82.14 71.69 91.93
🟢  src 94.33 90.9 60 93.61
🟢   detect-env.ts 92.3 86.66 100 91.3 15,85
🟢   env.ts 100 100 100 100
🟢   env.types.ts 100 100 100 100
🟡   fpjs-context.ts 80 100 0 80 38
🟡   get-env.ts 75 0 100 75 9-10
🟢   index.ts 100 100 0 100
🟢   ssr.ts 100 100 100 100
🟢   use-visitor-data.ts 97.72 100 87.5 97.29 79
🟢  src/components 90.66 75 86.66 92.75
🟢   fpjs-provider.tsx 88.52 69.23 83.33 91.22 112,118-123,142-144
🟢   with-environment.tsx 100 100 100 100
🟢  src/utils 85.71 57.14 87.5 82.6
🟡   assert-is-truthy.ts 66.66 0 100 66.66 3
🟡   to-error.ts 75 100 100 75 6
🟢   use-previous.ts 100 100 100 100
🟢   wait-until.ts 86.66 60 75 80 10-12

@JuroUhlar JuroUhlar force-pushed the fix/set-is-loading-right-away branch from bf52bd1 to 3194f33 Compare March 21, 2024 12:51
Copy link

This PR will create a patch release 🚀

2.6.3 (2024-03-21)

Bug Fixes

  • review (951860c)
  • set initial isLoading according to config.immediate (3194f33)

@JuroUhlar JuroUhlar merged commit 4217d8b into main Mar 21, 2024
8 checks passed
@JuroUhlar JuroUhlar deleted the fix/set-is-loading-right-away branch March 21, 2024 13:26
@fingerprint-dx-team
Copy link

🎉 This PR is included in version 2.6.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

neither data, error, or isLoading from useVisitorData is set.
2 participants